From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752897AbcBBGTz (ORCPT ); Tue, 2 Feb 2016 01:19:55 -0500 Received: from aserp1040.oracle.com ([141.146.126.69]:25038 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751164AbcBBGTx (ORCPT ); Tue, 2 Feb 2016 01:19:53 -0500 Message-ID: <1454394031.2873.10.camel@linux> Subject: [PATCH 1/1] xen-netfront: uninitialized fields in xenvif_rx_action From: Dongli Zhang To: ian.campbell@citrix.com Cc: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org Date: Tue, 02 Feb 2016 14:20:31 +0800 Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.10.4-0ubuntu2 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-Source-IP: userv0022.oracle.com [156.151.31.74] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org While npo.copy and npo.meta are initialized in xenvif_rx_action, fields such as npo.meta_prod are directly used later in xenvif_gop_skb without being initialized first. Although the output of xenvif_rx_action is based on the difference between new npo->meta_prod and old npo->meta_prod, it is better to initialize them to 0 at the beginning. Signed-off-by: Dongli Zhang --- drivers/net/xen-netback/netback.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/net/xen-netback/netback.c b/drivers/net/xen-netback/netback.c index 61b97c3..32f0fbd 100644 --- a/drivers/net/xen-netback/netback.c +++ b/drivers/net/xen-netback/netback.c @@ -560,6 +560,10 @@ static void xenvif_rx_action(struct xenvif_queue *queue) bool need_to_notify = false; struct netrx_pending_operations npo = { + .copy_prod = 0, + .copy_cons = 0, + .meta_prod = 0, + .meta_cons = 0, .copy = queue->grant_copy_op, .meta = queue->meta, }; -- 1.9.1