From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755284AbcBBMRF (ORCPT ); Tue, 2 Feb 2016 07:17:05 -0500 Received: from mail-vk0-f47.google.com ([209.85.213.47]:36828 "EHLO mail-vk0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755172AbcBBMRD (ORCPT ); Tue, 2 Feb 2016 07:17:03 -0500 From: Fabio Estevam To: broonie@kernel.org Cc: mail@maciej.szmigiero.name, linux-kernel@vger.kernel.org, Fabio Estevam Subject: [PATCH 1/2] regmap: Return an error if a caller attempts to do an unsupported raw read Date: Tue, 2 Feb 2016 10:16:50 -0200 Message-Id: <1454415411-14404-1-git-send-email-festevam@gmail.com> X-Mailer: git-send-email 1.9.1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Mark Brown regmaps without raw I/O access can't implement raw I/O operations, return an error if someone tries to do that rather than crashing. Signed-off-by: Mark Brown Signed-off-by: Fabio Estevam --- drivers/base/regmap/regmap.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/base/regmap/regmap.c b/drivers/base/regmap/regmap.c index 3432634..e2f6880 100644 --- a/drivers/base/regmap/regmap.c +++ b/drivers/base/regmap/regmap.c @@ -2255,6 +2255,9 @@ static int _regmap_raw_read(struct regmap *map, unsigned int reg, void *val, WARN_ON(!map->bus); + if (!map->bus || !map->bus->read) + return -EINVAL; + range = _regmap_range_lookup(map, reg); if (range) { ret = _regmap_select_page(map, ®, range, -- 1.9.1