From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754572AbcBBWwG (ORCPT ); Tue, 2 Feb 2016 17:52:06 -0500 Received: from smtprelay0228.hostedemail.com ([216.40.44.228]:45517 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754368AbcBBWv7 (ORCPT ); Tue, 2 Feb 2016 17:51:59 -0500 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::,RULES_HIT:41:355:379:541:599:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1381:1437:1515:1516:1518:1534:1540:1593:1594:1711:1730:1747:1777:1792:2393:2559:2562:2828:3138:3139:3140:3141:3142:3352:3622:3865:3866:3867:3868:3871:4321:5007:6261:10004:10249:10400:10848:11026:11232:11657:11658:11783:11914:12043:12048:12517:12519:12663:12740:13069:13311:13357:13894:13972:14659:21080,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:5,LUA_SUMMARY:none X-HE-Tag: truck70_4b2da6b3b143c X-Filterd-Recvd-Size: 1748 Message-ID: <1454453515.7291.44.camel@perches.com> Subject: Re: [PATCH] Staging: fix coding style in rtl8188eu/core From: Joe Perches To: Colin Vidal , Greg Kroah-Hartman , "open list:STAGING SUBSYSTEM" , open list Date: Tue, 02 Feb 2016 14:51:55 -0800 In-Reply-To: <1454448513.3898.3.camel@cvidal.org> References: <1454446679-17327-1-git-send-email-colin@cvidal.org> <1454447665.7291.40.camel@perches.com> <1454448513.3898.3.camel@cvidal.org> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.18.3-1ubuntu1 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2016-02-02 at 22:28 +0100, Colin Vidal wrote: > On Tue, 2016-02-02 at 13:14 -0800, Joe Perches wrote: > > On Tue, 2016-02-02 at 21:57 +0100, Colin Vidal wrote: > > > Set constant on the left of the test, and jump a new line to avoid to > > > exceed the 80 char length limit. > > [] > > > diff --git a/drivers/staging/rtl8188eu/core/rtw_iol.c b/drivers/staging/rtl8188eu/core/rtw_iol.c [] > > bool rtw_IOL_applied(struct adapter *adapter) > > { > > return adapter->registrypriv.fw_iol == 1 || > >        (adapter->registrypriv.fw_iol == 2 && > > !adapter_to_dvobj(adapter)->ishighspeed); > > } > > > > Oh, yeah, the second one is obviously finer. If I'm right, I should > resend a new patch with a subject which looks something like "[PATCH > v2] ... " ?  correct.