From: Namhyung Kim <namhyung@kernel.org>
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: Ingo Molnar <mingo@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Jiri Olsa <jolsa@kernel.org>, LKML <linux-kernel@vger.kernel.org>,
David Ahern <dsahern@gmail.com>, Andi Kleen <andi@firstfloor.org>,
Stephane Eranian <eranian@google.com>,
Wang Nan <wangnan0@huawei.com>
Subject: [RFC/PATCH 3/4] perf tools: Change default calchain percent limit to 0.05%
Date: Wed, 3 Feb 2016 23:11:22 +0900 [thread overview]
Message-ID: <1454508683-5735-3-git-send-email-namhyung@kernel.org> (raw)
In-Reply-To: <1454508683-5735-1-git-send-email-namhyung@kernel.org>
The current default limit of 0.5% is (mostly) for 'fractal' mode which
calculates the percentage relatively. As we changed the default
callchain mode to 'graph', the existing limit is too high IMHO.
Normally there're many entries under 0.5% overhead, it'd be supprising
that they don't show callchains.
Cc: Andi Kleen <andi@firstfloor.org>
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
---
changed from 0.005 -> 0.05
tools/perf/Documentation/perf-report.txt | 2 +-
tools/perf/builtin-report.c | 2 +-
tools/perf/builtin-top.c | 2 +-
tools/perf/util/util.c | 2 +-
4 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/tools/perf/Documentation/perf-report.txt b/tools/perf/Documentation/perf-report.txt
index 369663b37361..7c7b6b6129f7 100644
--- a/tools/perf/Documentation/perf-report.txt
+++ b/tools/perf/Documentation/perf-report.txt
@@ -209,7 +209,7 @@ OPTIONS
- none: disable call chain display.
threshold is a percentage value which specifies a minimum percent to be
- included in the output call graph. Default is 0.5 (%).
+ included in the output call graph. Default is 0.05 (%).
print_limit is only applied when stdio interface is used. It's to limit
number of call graph entries in a single hist entry. Note that it needs
diff --git a/tools/perf/builtin-report.c b/tools/perf/builtin-report.c
index 72ed0b46d5a1..d7ad5333d50f 100644
--- a/tools/perf/builtin-report.c
+++ b/tools/perf/builtin-report.c
@@ -643,7 +643,7 @@ parse_percent_limit(const struct option *opt, const char *str,
return 0;
}
-#define CALLCHAIN_DEFAULT_OPT "graph,0.5,caller,function,percent"
+#define CALLCHAIN_DEFAULT_OPT "graph,0.05,caller,function,percent"
const char report_callchain_help[] = "Display call graph (stack chain/backtrace):\n\n"
CALLCHAIN_REPORT_HELP
diff --git a/tools/perf/builtin-top.c b/tools/perf/builtin-top.c
index bf01cbb0ef23..f31cb78c92fb 100644
--- a/tools/perf/builtin-top.c
+++ b/tools/perf/builtin-top.c
@@ -1086,7 +1086,7 @@ parse_percent_limit(const struct option *opt, const char *arg,
}
const char top_callchain_help[] = CALLCHAIN_RECORD_HELP CALLCHAIN_REPORT_HELP
- "\n\t\t\t\tDefault: fp,graph,0.5,caller,function";
+ "\n\t\t\t\tDefault: fp,graph,0.05,caller,function";
int cmd_top(int argc, const char **argv, const char *prefix __maybe_unused)
{
diff --git a/tools/perf/util/util.c b/tools/perf/util/util.c
index b9e2843cfbe7..26b8f6c66d00 100644
--- a/tools/perf/util/util.c
+++ b/tools/perf/util/util.c
@@ -20,7 +20,7 @@
struct callchain_param callchain_param = {
.mode = CHAIN_GRAPH_ABS,
- .min_percent = 0.5,
+ .min_percent = 0.05,
.order = ORDER_CALLEE,
.key = CCKEY_FUNCTION,
.value = CCVAL_PERCENT,
--
2.7.0
next prev parent reply other threads:[~2016-02-03 14:12 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-03 14:11 [PATCH 1/4] perf report: Update document of --sort option Namhyung Kim
2016-02-03 14:11 ` [PATCH 2/4] perf report: Update document of --percent-limit option Namhyung Kim
2016-02-04 12:42 ` [tip:perf/core] perf report: Update documention " tip-bot for Namhyung Kim
2016-02-03 14:11 ` Namhyung Kim [this message]
2016-02-03 14:11 ` [PATCH 4/4] perf hists browser: Add 'L' key to change percent limit Namhyung Kim
2016-02-03 15:13 ` Arnaldo Carvalho de Melo
2016-02-04 12:43 ` [tip:perf/core] perf hists browser: Add 'L' hotkey " tip-bot for Namhyung Kim
2016-02-04 12:42 ` [tip:perf/core] perf report: Update documentation of --sort option tip-bot for Namhyung Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1454508683-5735-3-git-send-email-namhyung@kernel.org \
--to=namhyung@kernel.org \
--cc=acme@kernel.org \
--cc=andi@firstfloor.org \
--cc=dsahern@gmail.com \
--cc=eranian@google.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=wangnan0@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox