From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932719AbcBCX0b (ORCPT ); Wed, 3 Feb 2016 18:26:31 -0500 Received: from mail-am1on0109.outbound.protection.outlook.com ([157.56.112.109]:1664 "EHLO emea01-am1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1756498AbcBCX01 (ORCPT ); Wed, 3 Feb 2016 18:26:27 -0500 From: Marcel Ziswiler To: "shawnguo@kernel.org" CC: "linux-kernel@vger.kernel.org" , "shawn.guo@linaro.org" , "robh+dt@kernel.org" , "stefan@agner.ch" , "pawel.moll@arm.com" , "devicetree@vger.kernel.org" , "festevam@gmail.com" , "mark.rutland@arm.com" , "galak@codeaurora.org" , "ijc+devicetree@hellion.org.uk" , "stillcompiling@gmail.com" , "ynezz@true.cz" , "linux-arm-kernel@lists.infradead.org" , "l.stach@pengutronix.de" , "kernel@pengutronix.de" , "linux@arm.linux.org.uk" Subject: Re: [PATCH v4 1/2] ARM: dts: imx6: Add support for Toradex Apalis iMX6Q/D SoM Thread-Topic: [PATCH v4 1/2] ARM: dts: imx6: Add support for Toradex Apalis iMX6Q/D SoM Thread-Index: AQHRVvmBQ6Xfo79AhUicu9FP39NgCZ8XOyQAgAPLfYA= Date: Wed, 3 Feb 2016 23:26:23 +0000 Message-ID: <1454541981.11389.17.camel@toradex.com> References: <1453675703-31594-1-git-send-email-marcel.ziswiler@toradex.com> <1453675703-31594-2-git-send-email-marcel.ziswiler@toradex.com> <20160201132916.GF10671@tiger> In-Reply-To: <20160201132916.GF10671@tiger> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: kernel.org; dkim=none (message not signed) header.d=none;kernel.org; dmarc=none action=none header.from=toradex.com; x-originating-ip: [84.227.37.153] x-microsoft-exchange-diagnostics: 1;VI1PR05MB0973;5:Oob7H0J872nPr2RHKJGcOYENVHRrsAbVUyrGvIpNs1ctSdyVW8TcV20gitdC49yXDVlJsDGB2dPdLXJ/9e/kd+8rRxFjIYlkPhAQTnHiRuRizSraIYYtrQna97MsxvXBpW5TUgG1jYzMhVIu46AFtA==;24:XkZzsUx66go2AZtgwF/9qxnSttIx3KsmhBm4ZcIYB9R84oQJtOW8lNA1GbpQDyaqxuw/ttbWO6XO/qpR/yLUnesT9+m5gwaLhPnBlaqHVdE= x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:VI1PR05MB0973; x-ms-office365-filtering-correlation-id: f8a2128b-6405-47fd-75be-08d32cf16ea5 x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(601004)(2401047)(8121501046)(5005006)(3002001)(10201501046);SRVR:VI1PR05MB0973;BCL:0;PCL:0;RULEID:;SRVR:VI1PR05MB0973; x-forefront-prvs: 08417837C5 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(6009001)(377424004)(24454002)(2501003)(3280700002)(87936001)(2900100001)(92566002)(1220700001)(3660700001)(1096002)(102836003)(103116003)(1730700002)(586003)(3846002)(40100003)(2351001)(5001960100002)(5250100002)(4326007)(2906002)(6116002)(86362001)(50986999)(19580395003)(5008740100001)(189998001)(2950100001)(66066001)(76176999)(5004730100002)(5002640100001)(54356999)(106116001)(33646002)(11100500001)(36756003)(32563001);DIR:OUT;SFP:1102;SCL:1;SRVR:VI1PR05MB0973;H:VI1PR05MB0974.eurprd05.prod.outlook.com;FPR:;SPF:None;MLV:sfv;LANG:en; spamdiagnosticoutput: 1:23 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="utf-8" Content-ID: <4386F21F5813AD4883CBD4AD6EB21AA1@eurprd05.prod.outlook.com> MIME-Version: 1.0 X-OriginatorOrg: toradex.com X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Feb 2016 23:26:23.6480 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: d9995866-0d9b-4251-8315-093f062abab4 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR05MB0973 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id u13NQZjQ002048 On Mon, 2016-02-01 at 21:29 +0800, Shawn Guo wrote: [snip] > > + stmpe_touchscreen { > > Shouldn't the node name be generic as just touchscreen?  Or at least, > hyphen instead of underscore should be used in node name. This one is actually as per binding document example: Documentation/devicetree/bindings/input/touchscreen/stmpe.txt: Example:         stmpe_touchscreen { [snip]