From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964947AbcBDDNr (ORCPT ); Wed, 3 Feb 2016 22:13:47 -0500 Received: from mailgw02.mediatek.com ([69.46.227.142]:47434 "EHLO mailgw.mediatek.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1757147AbcBDDNp (ORCPT ); Wed, 3 Feb 2016 22:13:45 -0500 X-Greylist: delayed 602 seconds by postgrey-1.27 at vger.kernel.org; Wed, 03 Feb 2016 22:13:45 EST Message-ID: <1454555015.4618.10.camel@mussux00> Subject: Re: [PATCH 1/2] pinctrl: mediatek: fix direction control issue From: Hongzhou Yang To: Biao Huang CC: Linus Walleij , , , , , , Yingjoe Chen , Eddie Huang Date: Wed, 3 Feb 2016 19:03:35 -0800 In-Reply-To: <1454462686-770-2-git-send-email-biao.huang@mediatek.com> References: <1454462686-770-1-git-send-email-biao.huang@mediatek.com> <1454462686-770-2-git-send-email-biao.huang@mediatek.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.3-0ubuntu6 Content-Transfer-Encoding: 7bit MIME-Version: 1.0 X-MTK: N X-TM-AS-Product-Ver: SMEX-10.2.0.3308-8.000.1202-22108.005 X-TM-AS-Result: No--8.540800-8.000000-31 X-TM-AS-User-Approved-Sender: No X-TM-AS-User-Blocked-Sender: No Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2016-02-03 at 09:24 +0800, Biao Huang wrote: > Since input-enable/disable and input-schmitt-enable/disable are > workable when gpio direction is input, so add direction setting > when do input-enable/disable and input-schmitt-enable/disable > properties. > > Signed-off-by: Biao Huang > --- > drivers/pinctrl/mediatek/pinctrl-mtk-common.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/pinctrl/mediatek/pinctrl-mtk-common.c b/drivers/pinctrl/mediatek/pinctrl-mtk-common.c > index 8cac73d..6eb01c9 100644 > --- a/drivers/pinctrl/mediatek/pinctrl-mtk-common.c > +++ b/drivers/pinctrl/mediatek/pinctrl-mtk-common.c > @@ -352,6 +352,7 @@ static int mtk_pconf_parse_conf(struct pinctrl_dev *pctldev, > ret = mtk_pconf_set_pull_select(pctl, pin, true, false, arg); > break; > case PIN_CONFIG_INPUT_ENABLE: > + mtk_pmx_gpio_set_direction(pctldev, NULL, pin, true); > ret = mtk_pconf_set_ies_smt(pctl, pin, arg, param); Hi Linus, >>From pinctrl-bindings.txt, 'input-enable' property defined as following: input-enable - enable input on pin (no effect on output) Since input enable and input direction are two different settings on our SOC, could you tell me the exact meaning of this property? Input enable only? Or set input direction at the same time? Thanks, Hongzhou