From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965731AbcBDJRb (ORCPT ); Thu, 4 Feb 2016 04:17:31 -0500 Received: from mail-pf0-f195.google.com ([209.85.192.195]:36198 "EHLO mail-pf0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750966AbcBDJRJ (ORCPT ); Thu, 4 Feb 2016 04:17:09 -0500 From: Taeung Song To: Arnaldo Carvalho de Melo Cc: linux-kernel@vger.kernel.org, Jiri Olsa , Namhyung Kim , Ingo Molnar , Taeung Song , Jiri Olsa Subject: [PATCH v2] perf tools: bug fix, an error of parsing 'man..*' config variable. Date: Thu, 4 Feb 2016 18:17:03 +0900 Message-Id: <1454577423-16073-1-git-send-email-treeze.taeung@gmail.com> X-Mailer: git-send-email 2.5.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org To add new man viewer, configs like 'man..cmd', 'man..path' can be set into config file (~/.perfconfig). But parsing config file is stopped because the config variable contains '.' character i.e. If setting 'man.xman.cmd' into config file, [man] gman.cmd = gman when launching perf an error message is printed like below. Fatal: bad config file line 11 in /home/taeung/.perfconfig So modify iskeychar() function to decide '.' character as key character parsing config file. Cc: Namhyung Kim Cc: Jiri Olsa Signed-off-by: Taeung Song --- tools/perf/util/config.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/perf/util/config.c b/tools/perf/util/config.c index d3e12e3..3c01ced 100644 --- a/tools/perf/util/config.c +++ b/tools/perf/util/config.c @@ -122,7 +122,7 @@ static char *parse_value(void) static inline int iskeychar(int c) { - return isalnum(c) || c == '-' || c == '_'; + return isalnum(c) || c == '-' || c == '_' || c == '.'; } static int get_value(config_fn_t fn, void *data, char *name, unsigned int len) -- 2.5.0