public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: John Stultz <john.stultz@linaro.org>
To: linux-kernel@vger.kernel.org
Cc: San Mehat <san@google.com>, Jens Axboe <axboe@kernel.dk>,
	Rom Lemarchand <romlem@google.com>,
	Android Kernel Team <kernel-team@android.com>,
	Jeff Moyer <jmoyer@redhat.com>,
	harald@redhat.com, Kees Cook <keescook@chromium.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Kay Sievers <kay@vrfy.org>, Dima Zavin <dima@android.com>,
	John Stultz <john.stultz@linaro.org>
Subject: [RESEND x2][PATCH v2] block: partition: Add partition specific uevent callbacks for partition info
Date: Fri,  5 Feb 2016 10:01:43 -0800	[thread overview]
Message-ID: <1454695303-3181-1-git-send-email-john.stultz@linaro.org> (raw)

From: San Mehat <san@google.com>

This patch has been carried in the Android tree for quite some
time and is one of the few patches required to get a mainline
kernel up and running with an exsiting Android userspace. So I
wanted to submit it for review and consideration if it should
be merged.

For partitions, add new uevent parameters 'PARTN' which
specifies the partitions index in the table, and 'PARTNAME',
which specifies PARTNAME specifices the partition name of a
partition device.

Android's userspace uses this for creating device node links from the
partition name and number: ie:
	/dev/block/platform/soc/by-name/system
or
	/dev/block/platform/soc/by-num/p1

One can see its usage here:
https://android.googlesource.com/platform/system/core/+/master/init/devices.cpp#355
and
https://android.googlesource.com/platform/system/core/+/master/init/devices.cpp#494

Cc: Jens Axboe <axboe@kernel.dk>
Cc: Rom Lemarchand <romlem@google.com>
Cc: Android Kernel Team <kernel-team@android.com>
Cc: Jeff Moyer <jmoyer@redhat.com>
Cc: harald@redhat.com
Cc: Kees Cook <keescook@chromium.org>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Kay Sievers <kay@vrfy.org>
Signed-off-by: Dima Zavin <dima@android.com>
[Dropped NPARTS and reworded commit message for context]
Signed-off-by: John Stultz <john.stultz@linaro.org>
---
v2: Dropped NPARTS thanks to Jeff noticing it wasn't used

 block/partition-generic.c | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/block/partition-generic.c b/block/partition-generic.c
index 746935a..ae95e96 100644
--- a/block/partition-generic.c
+++ b/block/partition-generic.c
@@ -216,10 +216,21 @@ static void part_release(struct device *dev)
 	kfree(p);
 }
 
+static int part_uevent(struct device *dev, struct kobj_uevent_env *env)
+{
+	struct hd_struct *part = dev_to_part(dev);
+
+	add_uevent_var(env, "PARTN=%u", part->partno);
+	if (part->info && part->info->volname[0])
+		add_uevent_var(env, "PARTNAME=%s", part->info->volname);
+	return 0;
+}
+
 struct device_type part_type = {
 	.name		= "partition",
 	.groups		= part_attr_groups,
 	.release	= part_release,
+	.uevent		= part_uevent,
 };
 
 static void delete_partition_rcu_cb(struct rcu_head *head)
-- 
1.9.1

             reply	other threads:[~2016-02-05 18:01 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-05 18:01 John Stultz [this message]
2016-02-05 18:18 ` [RESEND x2][PATCH v2] block: partition: Add partition specific uevent callbacks for partition info Andrew Morton
2016-02-05 18:59   ` John Stultz
2016-02-06  2:38     ` Caizhiyong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1454695303-3181-1-git-send-email-john.stultz@linaro.org \
    --to=john.stultz@linaro.org \
    --cc=akpm@linux-foundation.org \
    --cc=axboe@kernel.dk \
    --cc=dima@android.com \
    --cc=harald@redhat.com \
    --cc=jmoyer@redhat.com \
    --cc=kay@vrfy.org \
    --cc=keescook@chromium.org \
    --cc=kernel-team@android.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=romlem@google.com \
    --cc=san@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox