From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754690AbcBGTjm (ORCPT ); Sun, 7 Feb 2016 14:39:42 -0500 Received: from smtprelay0055.hostedemail.com ([216.40.44.55]:52491 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752918AbcBGTjk (ORCPT ); Sun, 7 Feb 2016 14:39:40 -0500 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::,RULES_HIT:41:355:379:541:599:973:988:989:1260:1261:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2393:2559:2562:2828:3138:3139:3140:3141:3142:3352:3622:3865:3866:3867:3868:4321:5007:7652:10004:10400:10481:10848:11026:11232:11473:11657:11658:11783:11914:12043:12048:12296:12438:12517:12519:12740:13069:13255:13311:13357:13894:14659:19900:21080:30054:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:3,LUA_SUMMARY:none X-HE-Tag: edge77_8da44bc181607 X-Filterd-Recvd-Size: 2196 Message-ID: <1454869611.3739.8.camel@perches.com> Subject: Re: [PATCH 1/4] powerpc/ps3: gelic_udbg: use struct ethhdr from From: Joe Perches To: Luis Henriques , Geoff Levand , Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org In-Reply-To: <1454866730-10481-2-git-send-email-luis.henriques@canonical.com> References: <1454866730-10481-1-git-send-email-luis.henriques@canonical.com> <1454866730-10481-2-git-send-email-luis.henriques@canonical.com> Content-Type: text/plain; charset="ISO-8859-1" Date: Sun, 07 Feb 2016 10:26:51 -0800 Mime-Version: 1.0 X-Mailer: Evolution 3.18.3-1ubuntu1 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 2016-02-07 at 17:38 +0000, Luis Henriques wrote: > Instead of defining a local version of struct ethhdr use the standard > definition from . trivia: > diff --git a/arch/powerpc/platforms/ps3/gelic_udbg.c b/arch/powerpc/platforms/ps3/gelic_udbg.c [] > @@ -173,8 +169,8 @@ static void gelic_debug_init(void) >   >   h_eth = (struct ethhdr *)dbg.pkt; >   > - memset(&h_eth->dest, 0xff, 6); > - memcpy(&h_eth->src, &mac, 6); > + memset(&h_eth->h_dest, 0xff, 6); > + memcpy(&h_eth->h_source, &mac, 6); Be nice to use ETH_ALEN and eth_broadcast_addr. Maybe ether_addr_copy too. > @@ -183,7 +179,7 @@ static void gelic_debug_init(void) >    GELIC_LV1_VLAN_TX_ETHERNET_0, 0, 0, >    &vlan_id, &v2); >   if (!result) { > - h_eth->type = 0x8100; > + h_eth->h_proto= 0x8100; ETH_P_8021Q >   header_size += sizeof(struct vlantag); >   h_vlan = (struct vlantag *)(h_eth + 1); > @@ -191,7 +187,7 @@ static void gelic_debug_init(void) >   h_vlan->subtype = 0x0800; >   h_ip = (struct iphdr *)(h_vlan + 1); >   } else { > - h_eth->type = 0x0800; > + h_eth->h_proto= 0x0800; ETH_P_IP