From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753219AbcBHMqj (ORCPT ); Mon, 8 Feb 2016 07:46:39 -0500 Received: from mail-qg0-f53.google.com ([209.85.192.53]:34186 "EHLO mail-qg0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750866AbcBHMqi (ORCPT ); Mon, 8 Feb 2016 07:46:38 -0500 From: Kris Borer To: mmarek@suse.com Cc: Julia.Lawall@lip6.fr, Gilles.Muller@lip6.fr, nicolas.palix@imag.fr, linux-kernel@vger.kernel.org, cocci@systeme.lip6.fr, Kris Borer Subject: [PATCH v2] coccinelle: add style check for assignment in if Date: Mon, 8 Feb 2016 07:46:11 -0500 Message-Id: <1454935571-4054-1-git-send-email-kborer@gmail.com> X-Mailer: git-send-email 1.9.1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Add a semantic patch for fixing some cases of checkpatch.pl error: ERROR: do not use assignment in if condition Signed-off-by: Kris Borer --- scripts/coccinelle/style/assignment_in_if.cocci | 128 ++++++++++++++++++++++++ 1 file changed, 128 insertions(+) create mode 100644 scripts/coccinelle/style/assignment_in_if.cocci diff --git a/scripts/coccinelle/style/assignment_in_if.cocci b/scripts/coccinelle/style/assignment_in_if.cocci new file mode 100644 index 0000000..b23db8f --- /dev/null +++ b/scripts/coccinelle/style/assignment_in_if.cocci @@ -0,0 +1,128 @@ +/// move assignments out of if conditions +/// +//# This script is designed to correct code where assignments exist in if +//# conditions. It is only capable of handling a subset of such problems. +//# Ideally it would handle all checkpatch errors of the following type: +//# ERROR: do not use assignment in if condition +//# +//# For example: +//# if(result = myfun()) +//# +//# would become: +//# result = myfun(); +//# if(result) +// +// Confidence: Moderate +// Copyright: (C) 2015 Kris Borer. GPLv2. +// URL: http://coccinelle.lip6.fr/ +// Comments: +// Options: --no-includes --include-headers + +virtual patch + + +// if ( (ret = call()) ) +// if ( (ret = call()) < 0 ) +@if1@ +expression i; +expression E, E2; +statement S1, S2; +binary operator b; +@@ + ++ i = E; + if ( +( +- (i = E) ++ i +| +- (i = E) ++ i + b ... +| +- (i = E), + E2 +) + ) S1 else S2 + + +// if ( ptr->fun && (ret = ptr->fun()) ) +@if2@ +expression i2; +expression E1, E2; +@@ + ++ if( E1 ) { ++ i2 = E2; ++ if (i2) { +- if( E1 && (i2 = E2) ) { + ... +- } ++ } ++ } + + +// if ( ptr->fun && (ret = ptr->fun()) < 0 ) +@if3@ +expression i2; +expression E1, E2; +constant c; +binary operator b; +@@ + ++ if( E1 ) { ++ i2 = E2; ++ if (i2 b c) { +- if( E1 && ((i2 = E2) b c) ) { + ... +- } ++ } ++ } + + +// if ( (ret = call()) && ret != -1 ) +// if ( (ret = call()) < 0 && ret != -1 ) +@if4@ +expression i; +expression E, E2; +statement S1, S2; +binary operator b; +@@ + ++ i = E; + if ( +( +- (i = E) ++ i +| + ( +- (i = E) ++ i + b + ...) +) + && E2 ) S1 else S2 + + +// if ( (ret = call()) && ret != -1 && ret != -2 ) +// if ( (ret = call()) < 0 && ret != -1 && ret != -2 ) +@if5@ +expression i; +expression E, E2, E3; +statement S1, S2; +binary operator b; +@@ + ++ i = E; + if ( +( +- (i = E) ++ i +| + ( +- (i = E) ++ i + b + ...) +) + && E2 && E3 ) S1 else S2 -- 1.9.1