From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753249AbcBJTND (ORCPT ); Wed, 10 Feb 2016 14:13:03 -0500 Received: from e23smtp05.au.ibm.com ([202.81.31.147]:58404 "EHLO e23smtp05.au.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752298AbcBJTNA (ORCPT ); Wed, 10 Feb 2016 14:13:00 -0500 X-IBM-Helo: d23dlp01.au.ibm.com X-IBM-MailFrom: zohar@linux.vnet.ibm.com X-IBM-RcptTo: keyrings@vger.kernel.org;linux-kernel@vger.kernel.org;linux-security-module@vger.kernel.org Message-ID: <1455131523.2538.170.camel@linux.vnet.ibm.com> Subject: Re: [RFC PATCH 18/20] IMA: Use the system blacklist keyring [ver #2] From: Mimi Zohar To: David Howells Cc: linux-security-module@vger.kernel.org, keyrings@vger.kernel.org, petkan@mip-labs.com, linux-kernel@vger.kernel.org Date: Wed, 10 Feb 2016 14:12:03 -0500 In-Reply-To: <20160119113240.23238.31018.stgit@warthog.procyon.org.uk> References: <20160119113026.23238.4498.stgit@warthog.procyon.org.uk> <20160119113240.23238.31018.stgit@warthog.procyon.org.uk> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.12.11 (3.12.11-1.fc21) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 16021019-0017-0000-0000-000002C5C941 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi David, On Tue, 2016-01-19 at 11:32 +0000, David Howells wrote: > @@ -145,10 +165,10 @@ static int __init blacklist_init(void) > current_cred(), > (KEY_POS_ALL & ~KEY_POS_SETATTR) | > KEY_USR_VIEW | KEY_USR_READ | > - KEY_USR_SEARCH, > + KEY_USR_SEARCH | KEY_USR_WRITE, > KEY_ALLOC_NOT_IN_QUOTA | > KEY_FLAG_KEEP, > - NULL, NULL); > + restrict_link_by_system_trusted, NULL); As discussed, "restrict_link_by_system_trusted" is not enough. The certificate being added should be in a revoked list as well. We should defer this patch until that is possible or at least add a Kconfig option to permit black listing x509 certificates. Mimi