linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Marc Zyngier <marc.zyngier@arm.com>
To: Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will.deacon@arm.com>,
	Mark Rutland <mark.rutland@arm.com>,
	Christoffer Dall <christoffer.dall@linaro.org>
Cc: linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, kvm@vger.kernel.org,
	kvmarm@lists.cs.columbia.edu
Subject: [PATCH v4 18/23] arm64: KVM: VHE: Add alternative panic handling
Date: Thu, 11 Feb 2016 18:39:59 +0000	[thread overview]
Message-ID: <1455216004-19499-19-git-send-email-marc.zyngier@arm.com> (raw)
In-Reply-To: <1455216004-19499-1-git-send-email-marc.zyngier@arm.com>

As the kernel fully runs in HYP when VHE is enabled, we can
directly branch to the kernel's panic() implementation, and
not perform an exception return.

Add the alternative code to deal with this.

Reviewed-by: Christoffer Dall <christoffer.dall@linaro.org>
Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
---
 arch/arm64/kvm/hyp/switch.c | 35 +++++++++++++++++++++++++++--------
 1 file changed, 27 insertions(+), 8 deletions(-)

diff --git a/arch/arm64/kvm/hyp/switch.c b/arch/arm64/kvm/hyp/switch.c
index e609942..731f0a2 100644
--- a/arch/arm64/kvm/hyp/switch.c
+++ b/arch/arm64/kvm/hyp/switch.c
@@ -210,11 +210,34 @@ __alias(__guest_run) int __kvm_vcpu_run(struct kvm_vcpu *vcpu);
 
 static const char __hyp_panic_string[] = "HYP panic:\nPS:%08llx PC:%016llx ESR:%08llx\nFAR:%016llx HPFAR:%016llx PAR:%016llx\nVCPU:%p\n";
 
-void __hyp_text __noreturn __hyp_panic(void)
+static void __hyp_text __hyp_call_panic_nvhe(u64 spsr, u64 elr, u64 par)
 {
 	unsigned long str_va = (unsigned long)__hyp_panic_string;
-	u64 spsr = read_sysreg(spsr_el2);
-	u64 elr = read_sysreg(elr_el2);
+
+	__hyp_do_panic(hyp_kern_va(str_va),
+		       spsr,  elr,
+		       read_sysreg(esr_el2),   read_sysreg_el2(far),
+		       read_sysreg(hpfar_el2), par,
+		       (void *)read_sysreg(tpidr_el2));
+}
+
+static void __hyp_text __hyp_call_panic_vhe(u64 spsr, u64 elr, u64 par)
+{
+	panic(__hyp_panic_string,
+	      spsr,  elr,
+	      read_sysreg_el2(esr),   read_sysreg_el2(far),
+	      read_sysreg(hpfar_el2), par,
+	      (void *)read_sysreg(tpidr_el2));
+}
+
+static hyp_alternate_select(__hyp_call_panic,
+			    __hyp_call_panic_nvhe, __hyp_call_panic_vhe,
+			    ARM64_HAS_VIRT_HOST_EXTN);
+
+void __hyp_text __noreturn __hyp_panic(void)
+{
+	u64 spsr = read_sysreg_el2(spsr);
+	u64 elr = read_sysreg_el2(elr);
 	u64 par = read_sysreg(par_el1);
 
 	if (read_sysreg(vttbr_el2)) {
@@ -229,11 +252,7 @@ void __hyp_text __noreturn __hyp_panic(void)
 	}
 
 	/* Call panic for real */
-	__hyp_do_panic(hyp_kern_va(str_va),
-		       spsr,  elr,
-		       read_sysreg(esr_el2),   read_sysreg(far_el2),
-		       read_sysreg(hpfar_el2), par,
-		       (void *)read_sysreg(tpidr_el2));
+	__hyp_call_panic()(spsr, elr, par);
 
 	unreachable();
 }
-- 
2.1.4

  parent reply	other threads:[~2016-02-11 18:43 UTC|newest]

Thread overview: 43+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-11 18:39 [PATCH v4 00/23] arm64: Virtualization Host Extension support Marc Zyngier
2016-02-11 18:39 ` [PATCH v4 01/23] arm/arm64: KVM: Add hook for C-based stage2 init Marc Zyngier
2016-02-11 18:39 ` [PATCH v4 02/23] arm64: KVM: Switch to " Marc Zyngier
2016-02-11 18:39 ` [PATCH v4 03/23] arm/arm64: Add new is_kernel_in_hyp_mode predicate Marc Zyngier
2016-02-11 18:39 ` [PATCH v4 04/23] arm64: Allow the arch timer to use the HYP timer Marc Zyngier
2016-02-11 18:39 ` [PATCH v4 05/23] arm64: Add ARM64_HAS_VIRT_HOST_EXTN feature Marc Zyngier
2016-02-15 16:10   ` Will Deacon
2016-02-11 18:39 ` [PATCH v4 06/23] arm64: KVM: Skip HYP setup when already running in HYP Marc Zyngier
2016-02-11 18:39 ` [PATCH v4 07/23] arm64: KVM: VHE: Patch out use of HVC Marc Zyngier
2016-02-11 18:39 ` [PATCH v4 08/23] arm64: KVM: VHE: Patch out kern_hyp_va Marc Zyngier
2016-02-11 18:39 ` [PATCH v4 09/23] arm64: KVM: VHE: Introduce unified system register accessors Marc Zyngier
2016-02-11 18:39 ` [PATCH v4 10/23] arm64: KVM: VHE: Differenciate host/guest sysreg save/restore Marc Zyngier
2016-02-11 18:39 ` [PATCH v4 11/23] arm64: KVM: VHE: Split save/restore of registers shared between guest and host Marc Zyngier
2016-02-11 18:39 ` [PATCH v4 12/23] arm64: KVM: VHE: Use unified system register accessors Marc Zyngier
2016-02-11 18:39 ` [PATCH v4 13/23] arm64: KVM: VHE: Enable minimal sysreg save/restore Marc Zyngier
2016-02-11 18:39 ` [PATCH v4 14/23] arm64: KVM: VHE: Make __fpsimd_enabled VHE aware Marc Zyngier
2016-02-11 18:39 ` [PATCH v4 15/23] arm64: KVM: VHE: Implement VHE activate/deactivate_traps Marc Zyngier
2016-02-11 18:39 ` [PATCH v4 16/23] arm64: KVM: VHE: Use unified sysreg accessors for timer Marc Zyngier
2016-02-11 18:39 ` [PATCH v4 17/23] arm64: KVM: VHE: Add fpsimd enabling on guest access Marc Zyngier
2016-02-11 18:39 ` Marc Zyngier [this message]
2016-02-11 18:40 ` [PATCH v4 19/23] arm64: KVM: Move most of the fault decoding to C Marc Zyngier
2016-02-11 18:40 ` [PATCH v4 20/23] arm64: perf: Count EL2 events if the kernel is running in HYP Marc Zyngier
2016-02-15 17:22   ` Will Deacon
2016-02-15 18:23     ` Marc Zyngier
2016-02-15 18:27       ` Will Deacon
2016-02-11 18:40 ` [PATCH v4 21/23] arm64: hw_breakpoint: Allow EL2 breakpoints if " Marc Zyngier
2016-02-15 10:22   ` Catalin Marinas
2016-02-15 17:46   ` Will Deacon
2016-02-15 19:07     ` Will Deacon
2016-02-16  9:55       ` Marc Zyngier
2016-02-17 17:57   ` [PATCH v4.1] arm64: perf: Count EL2 events if the kernel is " Marc Zyngier
2016-02-19 14:30     ` Will Deacon
2016-02-11 18:40 ` [PATCH v4 22/23] arm64: VHE: Add support for running Linux in EL2 mode Marc Zyngier
2016-02-17 17:58   ` [PATCH v4.1] arm64: hw_breakpoint: Allow EL2 breakpoints if running in HYP Marc Zyngier
2016-02-19 14:30     ` Will Deacon
2016-02-11 18:40 ` [PATCH v4 23/23] arm64: Panic when VHE and non VHE CPUs coexist Marc Zyngier
2016-02-15 17:26   ` Will Deacon
2016-02-15 18:14     ` Marc Zyngier
2016-02-11 19:07 ` [PATCH v4 00/23] arm64: Virtualization Host Extension support Christoffer Dall
2016-02-11 19:10   ` Marc Zyngier
2016-02-15 10:23     ` Catalin Marinas
2016-02-15 10:34       ` Marc Zyngier
2016-02-29 17:43 ` Alex Bennée

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1455216004-19499-19-git-send-email-marc.zyngier@arm.com \
    --to=marc.zyngier@arm.com \
    --cc=catalin.marinas@arm.com \
    --cc=christoffer.dall@linaro.org \
    --cc=kvm@vger.kernel.org \
    --cc=kvmarm@lists.cs.columbia.edu \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=will.deacon@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).