From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751510AbcBMODc (ORCPT ); Sat, 13 Feb 2016 09:03:32 -0500 Received: from mail-pf0-f174.google.com ([209.85.192.174]:33131 "EHLO mail-pf0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751231AbcBMODa (ORCPT ); Sat, 13 Feb 2016 09:03:30 -0500 From: Sudip Mukherjee To: Florian Fainelli , "David S. Miller" Cc: linux-kernel@vger.kernel.org, kernel-testers@vger.kernel.org, netdev@vger.kernel.org, Geert Uytterhoeven , Sudip Mukherjee , Helmut Buchsbaum Subject: [PATCH v2] net: phy: spi_ks8995: add dependency on GPIO Date: Sat, 13 Feb 2016 19:33:15 +0530 Message-Id: <1455372195-10825-1-git-send-email-sudipm.mukherjee@gmail.com> X-Mailer: git-send-email 1.9.1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The builds of allmodconfig of s390, m68k, tilegx, tilepro is failing with the error: drivers/net/phy/spi_ks8995.c:477:3: error: implicit declaration of function 'gpiod_set_value' drivers/net/phy/spi_ks8995.c:477:19: error: implicit declaration of function 'gpio_to_desc' GPIO is now used to reset the switch so we should have a dependency on GPIOLIB. While adding the dependency also add COMPILE_TEST so that we can build test it. Fixes: cd6f288cbaab ("net: phy: spi_ks8995: add support for resetting switch using GPIO") Cc: Helmut Buchsbaum Signed-off-by: Sudip Mukherjee --- v2: added COMPILE_TEST and gpio/consumer.h drivers/net/phy/Kconfig | 1 + drivers/net/phy/spi_ks8995.c | 1 + 2 files changed, 2 insertions(+) diff --git a/drivers/net/phy/Kconfig b/drivers/net/phy/Kconfig index f0a7702..186f202 100644 --- a/drivers/net/phy/Kconfig +++ b/drivers/net/phy/Kconfig @@ -262,3 +262,4 @@ endif # PHYLIB config MICREL_KS8995MA tristate "Micrel KS8995MA 5-ports 10/100 managed Ethernet switch" depends on SPI + depends on GPIOLIB || COMPILE_TEST diff --git a/drivers/net/phy/spi_ks8995.c b/drivers/net/phy/spi_ks8995.c index 5e7340f..55000f6 100644 --- a/drivers/net/phy/spi_ks8995.c +++ b/drivers/net/phy/spi_ks8995.c @@ -20,6 +20,7 @@ #include #include #include +#include #include #include -- 1.9.1