From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751681AbcBOPPj (ORCPT ); Mon, 15 Feb 2016 10:15:39 -0500 Received: from mga14.intel.com ([192.55.52.115]:39689 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751123AbcBOPPh (ORCPT ); Mon, 15 Feb 2016 10:15:37 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.22,450,1449561600"; d="scan'208";a="48152240" Message-ID: <1455549376.31169.127.camel@linux.intel.com> Subject: Re: [PATCH 02/14] clkdev: Remove clk_register_clkdevs() From: Andy Shevchenko To: Stephen Boyd , Mike Turquette Cc: linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Russell King Date: Mon, 15 Feb 2016 17:16:16 +0200 In-Reply-To: <1454982341-22715-3-git-send-email-sboyd@codeaurora.org> References: <1454982341-22715-1-git-send-email-sboyd@codeaurora.org> <1454982341-22715-3-git-send-email-sboyd@codeaurora.org> Organization: Intel Finland Oy Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.18.3-1 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2016-02-08 at 17:45 -0800, Stephen Boyd wrote: > Now that we've converted the only caller over to another clkdev > API, remove this one. > This API didn't feel suitable, good we get rid of it eventually. Reviewed-by: Andy Shevchenko >  > Cc: Andy Shevchenko > Cc: Russell King > Signed-off-by: Stephen Boyd > --- >  drivers/clk/clkdev.c   | 27 --------------------------- >  include/linux/clkdev.h |  1 - >  2 files changed, 28 deletions(-) > > diff --git a/drivers/clk/clkdev.c b/drivers/clk/clkdev.c > index 779b6ff0c7ad..ae61f2e57048 100644 > --- a/drivers/clk/clkdev.c > +++ b/drivers/clk/clkdev.c > @@ -383,30 +383,3 @@ int clk_register_clkdev(struct clk *clk, const > char *con_id, >   return cl ? 0 : -ENOMEM; >  } >  EXPORT_SYMBOL(clk_register_clkdev); > - > -/** > - * clk_register_clkdevs - register a set of clk_lookup for a struct > clk > - * @clk: struct clk to associate with all clk_lookups > - * @cl: array of clk_lookup structures with con_id and dev_id pre- > initialized > - * @num: number of clk_lookup structures to register > - * > - * To make things easier for mass registration, we detect error clks > - * from a previous clk_register() call, and return the error code > for > - * those.  This is to permit this function to be called immediately > - * after clk_register(). > - */ > -int clk_register_clkdevs(struct clk *clk, struct clk_lookup *cl, > size_t num) > -{ > - unsigned i; > - > - if (IS_ERR(clk)) > - return PTR_ERR(clk); > - > - for (i = 0; i < num; i++, cl++) { > - cl->clk_hw = __clk_get_hw(clk); > - __clkdev_add(cl); > - } > - > - return 0; > -} > -EXPORT_SYMBOL(clk_register_clkdevs); > diff --git a/include/linux/clkdev.h b/include/linux/clkdev.h > index 08bffcc466de..43a8c2e8ac29 100644 > --- a/include/linux/clkdev.h > +++ b/include/linux/clkdev.h > @@ -46,7 +46,6 @@ int clk_add_alias(const char *, const char *, const > char *, struct device *); >   >  int clk_register_clkdev(struct clk *, const char *, const char *, > ...) >   __printf(3, 4); > -int clk_register_clkdevs(struct clk *, struct clk_lookup *, size_t); >   >  #ifdef CONFIG_COMMON_CLK >  int __clk_get(struct clk *clk); -- Andy Shevchenko Intel Finland Oy