From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752744AbcBORJp (ORCPT ); Mon, 15 Feb 2016 12:09:45 -0500 Received: from smtprelay0064.hostedemail.com ([216.40.44.64]:57342 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751208AbcBORJo (ORCPT ); Mon, 15 Feb 2016 12:09:44 -0500 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::::::,RULES_HIT:41:355:379:541:599:800:960:973:982:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1540:1593:1594:1711:1730:1747:1777:1792:2393:2559:2562:2828:3138:3139:3140:3141:3142:3352:3622:3865:3866:3870:4321:5007:6261:10004:10400:10848:11026:11232:11658:11783:11914:12043:12296:12517:12519:12740:13069:13311:13357:13894:14659:21060:21080:30054:30064:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:4,LUA_SUMMARY:none X-HE-Tag: face87_1a2ee18ed591f X-Filterd-Recvd-Size: 1973 Message-ID: <1455556178.4046.14.camel@perches.com> Subject: Re: [PATCH] Bluetooth: hci_uart: fix boolreturn.cocci warnings From: Joe Perches To: kbuild test robot , Amitkumar Karwar Cc: kbuild-all@01.org, linux-bluetooth@vger.kernel.org, Nishant Sarmukadam , linux-kernel@vger.kernel.org, Cathy Luo , marcel@holtmann.org, Ganapathi Bhat Date: Mon, 15 Feb 2016 09:09:38 -0800 In-Reply-To: <20160215162557.GA65463@lkp-hsx03> References: <201602160006.xiXzASZ0%fengguang.wu@intel.com> <20160215162557.GA65463@lkp-hsx03> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.18.4-0ubuntu1 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2016-02-16 at 00:25 +0800, kbuild test robot wrote: > drivers/bluetooth/hci_mrvl.c:411:9-10: WARNING: return of 0/1 in > function 'mrvl_fw_loaded' with return type bool > >  Return statements in functions returning bool should use >  true/false instead of 1/0. > Generated by: scripts/coccinelle/misc/boolreturn.cocci > > CC: Ganapathi Bhat > Signed-off-by: Fengguang Wu > --- > >  hci_mrvl.c |    4 ++-- >  1 file changed, 2 insertions(+), 2 deletions(-) > > --- a/drivers/bluetooth/hci_mrvl.c > +++ b/drivers/bluetooth/hci_mrvl.c > @@ -408,9 +408,9 @@ static bool mrvl_fw_loaded(struct hci_ua >   struct fw_data *fw_data = mrvl->fwdata; >   >   if ((get_cts(hu->tty)) || (fw_data->fw_loaded)) > - return 1; > + return true; >   else > - return 0; > + return false; >  } Nicer might be return get_cts(hu->tty) || fw_data->fw_loaded;   >  /* Set the baud rate */