From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1161148AbcBQKpL (ORCPT ); Wed, 17 Feb 2016 05:45:11 -0500 Received: from smtprelay0001.hostedemail.com ([216.40.44.1]:59307 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1030300AbcBQKpJ (ORCPT ); Wed, 17 Feb 2016 05:45:09 -0500 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::,RULES_HIT:41:355:379:541:599:960:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1539:1593:1594:1711:1714:1730:1747:1777:1792:2393:2559:2562:2828:2904:3138:3139:3140:3141:3142:3351:3622:3865:3867:3868:3871:3872:4321:5007:6261:10004:10400:10848:11026:11658:11783:11914:12043:12296:12517:12519:12740:13069:13095:13311:13357:13894:14659:21080:30054:30064:30070:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:1,LUA_SUMMARY:none X-HE-Tag: cloud58_84079390b1209 X-Filterd-Recvd-Size: 1604 Message-ID: <1455705906.4745.13.camel@perches.com> Subject: Re: [char-misc-next] mei: fix format string in debug prints From: Joe Perches To: Tomas Winkler , Greg Kroah-Hartman Cc: Alexander Usyskin , linux-kernel@vger.kernel.org Date: Wed, 17 Feb 2016 02:45:06 -0800 In-Reply-To: <1455704877-32066-1-git-send-email-tomas.winkler@intel.com> References: <1455704877-32066-1-git-send-email-tomas.winkler@intel.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.18.4-0ubuntu1 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2016-02-17 at 12:27 +0200, Tomas Winkler wrote: [] > buf_idx type was changed to size_t, and few places > missed out to change the print format from %ld to %zd. trivia: > diff --git a/drivers/misc/mei/interrupt.c b/drivers/misc/mei/interrupt.c [] > @@ -128,7 +128,7 @@ int mei_cl_irq_read_msg(struct mei_cl *cl, >   buf_sz = mei_hdr->length + cb->buf_idx; >   /* catch for integer overflow */ >   if (buf_sz < cb->buf_idx) { > - cl_err(dev, cl, "message is too big len %d idx %ld\n", > + cl_err(dev, cl, "message is too big len %d idx %zd\n", >          mei_hdr->length, cb->buf_idx); [etc...] buf_idx is size_t and it should probably use %zu ssize_t -> %zd size_t -> %zu