From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1423685AbcBQO7w (ORCPT ); Wed, 17 Feb 2016 09:59:52 -0500 Received: from g4t3428.houston.hp.com ([15.201.208.56]:47266 "EHLO g4t3428.houston.hp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933826AbcBQO7u (ORCPT ); Wed, 17 Feb 2016 09:59:50 -0500 Message-ID: <1455724367.2925.209.camel@hpe.com> Subject: Re: [PATCH v3 1/2] x86/lib/copy_user_64.S: cleanup __copy_user_nocache() From: Toshi Kani To: Ingo Molnar Cc: tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com, bp@suse.de, dan.j.williams@intel.com, ross.zwisler@linux.intel.com, vishal.l.verma@intel.com, micah.parrish@hpe.com, brian.boylston@hpe.com, x86@kernel.org, linux-nvdimm@ml01.01.org, linux-kernel@vger.kernel.org Date: Wed, 17 Feb 2016 08:52:47 -0700 In-Reply-To: <20160217080235.GA20160@gmail.com> References: <1455225857-12039-1-git-send-email-toshi.kani@hpe.com> <1455225857-12039-2-git-send-email-toshi.kani@hpe.com> <20160217080235.GA20160@gmail.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.18.4 (3.18.4-1.fc23) Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2016-02-17 at 09:02 +0100, Ingo Molnar wrote: > * Toshi Kani wrote: > > > Add comments to __copy_user_nocache() to clarify its procedures > > and alignment requirement. > > > > Also change numeric branch target labels to named labels.  The > > labels begin with ".L" and prefix "cun" (Copy User Nocache) to > > keep them local and unique to the function. > > So the .L labels are local, i.e. they are not emitted into the symbol > table. > > I.e. no need to name them globally! Right, but I thought there is risk of conflicting the names with other copy functions in the file when they also start using descriptive labels.  For instance, ".L_finish_copy" can be easily used by other copy functions as well. > I've done a s/Lcun_/L_/ over the patch. Thanks, -Toshi