linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH RESEND] dpt_i2o: fix build warning
@ 2016-02-18  8:29 Sudip Mukherjee
  2016-02-23 22:44 ` Martin K. Petersen
  0 siblings, 1 reply; 2+ messages in thread
From: Sudip Mukherjee @ 2016-02-18  8:29 UTC (permalink / raw)
  To: Adaptec OEM Raid Solutions, Martin K. Petersen
  Cc: linux-kernel, linux-scsi, Johannes Thumshirn, Sudip Mukherjee

We were getting build warning about:
drivers/scsi/dpt_i2o.c:183:29: warning: 'dptids' defined but not used

dptids[] is only used in the MODULE_DEVICE_TABLE so when MODULE is not
defined then dptids[] becomes unused.

Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de>
Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
---

Resending v1 as v2 had a NACK from Alan about the spec not maintained
while converting to pci driver.

 drivers/scsi/dpt_i2o.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/scsi/dpt_i2o.c b/drivers/scsi/dpt_i2o.c
index d4cda5e..21c8d21 100644
--- a/drivers/scsi/dpt_i2o.c
+++ b/drivers/scsi/dpt_i2o.c
@@ -180,11 +180,14 @@ static u8 adpt_read_blink_led(adpt_hba* host)
  *============================================================================
  */
 
+#ifdef MODULE
 static struct pci_device_id dptids[] = {
 	{ PCI_DPT_VENDOR_ID, PCI_DPT_DEVICE_ID, PCI_ANY_ID, PCI_ANY_ID,},
 	{ PCI_DPT_VENDOR_ID, PCI_DPT_RAPTOR_DEVICE_ID, PCI_ANY_ID, PCI_ANY_ID,},
 	{ 0, }
 };
+#endif
+
 MODULE_DEVICE_TABLE(pci,dptids);
 
 static int adpt_detect(struct scsi_host_template* sht)
-- 
1.9.1

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH RESEND] dpt_i2o: fix build warning
  2016-02-18  8:29 [PATCH RESEND] dpt_i2o: fix build warning Sudip Mukherjee
@ 2016-02-23 22:44 ` Martin K. Petersen
  0 siblings, 0 replies; 2+ messages in thread
From: Martin K. Petersen @ 2016-02-23 22:44 UTC (permalink / raw)
  To: Sudip Mukherjee
  Cc: Adaptec OEM Raid Solutions, Martin K. Petersen, linux-kernel,
	linux-scsi, Johannes Thumshirn

>>>>> "Sudip" == Sudip Mukherjee <sudipm.mukherjee@gmail.com> writes:

Sudip> We were getting build warning about:
Sudip> drivers/scsi/dpt_i2o.c:183:29: warning: 'dptids' defined but not
Sudip> used

Sudip> dptids[] is only used in the MODULE_DEVICE_TABLE so when MODULE
Sudip> is not defined then dptids[] becomes unused.

Applied to 4.6/scsi-queue.

-- 
Martin K. Petersen	Oracle Linux Engineering

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2016-02-23 22:45 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-02-18  8:29 [PATCH RESEND] dpt_i2o: fix build warning Sudip Mukherjee
2016-02-23 22:44 ` Martin K. Petersen

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).