From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1425904AbcBRJiT (ORCPT ); Thu, 18 Feb 2016 04:38:19 -0500 Received: from mx2.suse.de ([195.135.220.15]:58601 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1425807AbcBRJiR (ORCPT ); Thu, 18 Feb 2016 04:38:17 -0500 Message-ID: <1455788141.1384.16.camel@suse.com> Subject: Re: [PATCH 1/3] usb: USB Type-C Connector Class From: Oliver Neukum To: Heikki Krogerus Cc: Felipe Balbi , Mathias Nyman , Greg KH , linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org Date: Thu, 18 Feb 2016 10:35:41 +0100 In-Reply-To: <20160218084724.GA1859@kuha.fi.intel.com> References: <1455037283-106479-1-git-send-email-heikki.krogerus@linux.intel.com> <1455037283-106479-2-git-send-email-heikki.krogerus@linux.intel.com> <1455718047.7626.22.camel@suse.com> <20160218084724.GA1859@kuha.fi.intel.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.12.11 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2016-02-18 at 10:47 +0200, Heikki Krogerus wrote: Hi, > P.S. That reminds me, here's my current draft for the > Documentation/ABI/. Could you take a look? And I am afraid, that I have a few remarks not bound to a specific entry. We have port directories for port power switching. How is the connector directory linked to them? Likewise, if we have USB PD, we have to know how that is linked to the connector directory. In addition, writes to those files have results. We need the error codes to be described. Furthermore, do these files support poll? And lastly we can get "Attention" as a message connected with a connector in an alternate mode. How does user space learn about that? I am sorry to be this obnoxious, but this is an API which will be with us for a long time, so we better get it right. HTH Oliver