From: Alexander Kochetkov <al.kochet@gmail.com>
To: Vinod Koul <vinod.koul@intel.com>
Cc: Dan Williams <dan.j.williams@intel.com>,
dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org,
Shawn Lin <shawn.lin@rock-chips.com>,
Addy Ke <addy.ke@rock-chips.com>,
Boojin Kim <boojin.kim@samsung.com>,
Alexander Kochetkov <al.kochet@gmail.com>
Subject: [PATCH 2/4] dmaengine: pl330: cleanup brst_len usage
Date: Thu, 18 Feb 2016 15:31:12 +0300 [thread overview]
Message-ID: <1455798674-10186-3-git-send-email-al.kochet@gmail.com> (raw)
In-Reply-To: <1455798674-10186-1-git-send-email-al.kochet@gmail.com>
brst_len can be extracted from ccr register
in ldst_devtomem() and ldst_memtodev().
Signed-off-by: Alexander Kochetkov <al.kochet@gmail.com>
---
drivers/dma/pl330.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/dma/pl330.c b/drivers/dma/pl330.c
index 7a17c0f..9ce6c10 100644
--- a/drivers/dma/pl330.c
+++ b/drivers/dma/pl330.c
@@ -1161,7 +1161,7 @@ static inline int _ldst_devtomem(unsigned dry_run, u8 buf[],
if (pxs->quirks & PL330_QUIRK_BROKEN_NO_FLUSHP)
cond = BURST;
else
- cond = (pxs->desc->rqcfg.brst_len == 1) ? SINGLE : BURST;
+ cond = (BRST_LEN(pxs->ccr) == 1) ? SINGLE : BURST;
while (cyc--) {
off += _emit_WFP(dry_run, &buf[off], cond, pxs->desc->peri);
@@ -1185,8 +1185,7 @@ static inline int _ldst_memtodev(unsigned dry_run, u8 buf[],
if (pxs->quirks & PL330_QUIRK_BROKEN_NO_FLUSHP)
cond = BURST;
else
- cond = (pxs->desc->rqcfg.brst_len == 1) ? SINGLE : BURST;
-
+ cond = (BRST_LEN(pxs->ccr) == 1) ? SINGLE : BURST;
while (cyc--) {
off += _emit_WFP(dry_run, &buf[off], cond, pxs->desc->peri);
--
1.7.9.5
next prev parent reply other threads:[~2016-02-18 12:31 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-18 12:31 Cleanups and improvenments for pl330 Alexander Kochetkov
2016-02-18 12:31 ` [PATCH 1/4] dmaengine: pl330: cleanup quirk pass code Alexander Kochetkov
2016-02-18 12:31 ` Alexander Kochetkov [this message]
2016-02-18 12:31 ` [PATCH 3/4] dmaengine: pl330: don't emit code for one iteration loop Alexander Kochetkov
2016-02-18 12:31 ` [PATCH 4/4] dmaengine: pl330: make cyclic transfer free runnable Alexander Kochetkov
2016-03-08 3:03 ` Cleanups and improvenments for pl330 Vinod Koul
2016-03-10 10:57 ` [PATCH 1/3 v2] dmaengine: pl330: cleanup quirk pass code Alexander Kochetkov
2016-03-10 10:57 ` [PATCH 2/3 v2] dmaengine: pl330: don't emit code for one iteration loop Alexander Kochetkov
2016-03-10 10:57 ` [PATCH 3/3 v2] dmaengine: pl330: make cyclic transfer free runnable Alexander Kochetkov
2016-03-10 11:02 ` Cleanups and improvenments for pl330 v3 Alexander Kochetkov
2016-03-10 11:02 ` [PATCH 1/3 v3] dmaengine: pl330: cleanup quirk pass code Alexander Kochetkov
2016-03-10 11:02 ` [PATCH 2/3 v3] dmaengine: pl330: don't emit code for one iteration loop Alexander Kochetkov
2016-03-10 11:02 ` [PATCH 3/3 v3] dmaengine: pl330: make cyclic transfer free runnable Alexander Kochetkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1455798674-10186-3-git-send-email-al.kochet@gmail.com \
--to=al.kochet@gmail.com \
--cc=addy.ke@rock-chips.com \
--cc=boojin.kim@samsung.com \
--cc=dan.j.williams@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=shawn.lin@rock-chips.com \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).