From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1947325AbcBRRWP (ORCPT ); Thu, 18 Feb 2016 12:22:15 -0500 Received: from mail-pf0-f170.google.com ([209.85.192.170]:34712 "EHLO mail-pf0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1947220AbcBRRWK (ORCPT ); Thu, 18 Feb 2016 12:22:10 -0500 From: Anand Moon To: Vinod Koul , Dan Williams , Anand Moon Cc: dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] dmaengine: pl330: initialize tasklet after spin_unlock_irqrestore Date: Thu, 18 Feb 2016 22:51:50 +0530 Message-Id: <1455816110-2799-1-git-send-email-linux.amoon@gmail.com> X-Mailer: git-send-email 1.9.1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Anand Moon pl330_tasklet tasklet uses the same spinlock pch->lock for safe IRQ locking. It's safe to initialize pl330_tasklet tasklet after release of the locking. Signed-off-by: Anand Moon --- drivers/dma/pl330.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/dma/pl330.c b/drivers/dma/pl330.c index 17ee758..df2cab1 100644 --- a/drivers/dma/pl330.c +++ b/drivers/dma/pl330.c @@ -2091,10 +2091,10 @@ static int pl330_alloc_chan_resources(struct dma_chan *chan) return -ENOMEM; } - tasklet_init(&pch->task, pl330_tasklet, (unsigned long) pch); - spin_unlock_irqrestore(&pch->lock, flags); + tasklet_init(&pch->task, pl330_tasklet, (unsigned long) pch); + return 1; } -- 1.9.1