From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1161199AbcBRRk0 (ORCPT ); Thu, 18 Feb 2016 12:40:26 -0500 Received: from mail-pf0-f179.google.com ([209.85.192.179]:35974 "EHLO mail-pf0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756336AbcBRRkW (ORCPT ); Thu, 18 Feb 2016 12:40:22 -0500 From: Anand Moon To: Greg Kroah-Hartman , Jiri Slaby , Anand Moon Cc: linux-serial@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] serial: samsung: fix the inconsistency in spinlock Date: Thu, 18 Feb 2016 23:10:02 +0530 Message-Id: <1455817202-3005-1-git-send-email-linux.amoon@gmail.com> X-Mailer: git-send-email 1.9.1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Anand Moon changes fix the correct order of the spin_lock_irqrestore/save. Signed-off-by: Anand Moon --- drivers/tty/serial/samsung.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/tty/serial/samsung.c b/drivers/tty/serial/samsung.c index d72cd73..96fe14d 100644 --- a/drivers/tty/serial/samsung.c +++ b/drivers/tty/serial/samsung.c @@ -759,9 +759,9 @@ static irqreturn_t s3c24xx_serial_tx_chars(int irq, void *id) } if (uart_circ_chars_pending(xmit) < WAKEUP_CHARS) { - spin_unlock(&port->lock); + spin_unlock_irqrestore(&port->lock, flags); uart_write_wakeup(port); - spin_lock(&port->lock); + spin_lock_irqsave(&port->lock, flags); } if (uart_circ_empty(xmit)) -- 1.9.1