From: Anand Moon <linux.amoon@gmail.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jslaby@suse.com>,
Peter Hurley <peter@hurleysoftware.com>
Cc: linux-serial@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
linux-kernel@vger.kernel.org, Anand Moon <linux.amoon@gmail.com>
Subject: [PATCHv2] serial: samsung: drop the spinlock around uart_write_wakeup
Date: Fri, 19 Feb 2016 10:45:37 +0530 [thread overview]
Message-ID: <1455858937-2380-1-git-send-email-linux.amoon@gmail.com> (raw)
From: Anand Moon <linux.amoon@gmail.com>
drop the spin_unlock/lock around uart_write_wakeup to protect
write wakeup for uart port.
Signed-off-by: Anand Moon <linux.amoon@gmail.com>
---
changes logs: drop the previous approch of spin_unlock_irqrestore/save
---
drivers/tty/serial/samsung.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/tty/serial/samsung.c b/drivers/tty/serial/samsung.c
index d72cd73..0cb70a9 100644
--- a/drivers/tty/serial/samsung.c
+++ b/drivers/tty/serial/samsung.c
@@ -758,11 +758,8 @@ static irqreturn_t s3c24xx_serial_tx_chars(int irq, void *id)
goto out;
}
- if (uart_circ_chars_pending(xmit) < WAKEUP_CHARS) {
- spin_unlock(&port->lock);
+ if (uart_circ_chars_pending(xmit) < WAKEUP_CHARS)
uart_write_wakeup(port);
- spin_lock(&port->lock);
- }
if (uart_circ_empty(xmit))
s3c24xx_serial_stop_tx(port);
--
1.9.1
next reply other threads:[~2016-02-19 5:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-19 5:15 Anand Moon [this message]
2016-02-19 19:30 ` [PATCHv2] serial: samsung: drop the spinlock around uart_write_wakeup Peter Hurley
2016-02-20 3:36 ` Anand Moon
2016-02-21 1:37 ` Krzysztof Kozlowski
2016-02-21 2:59 ` Anand Moon
2016-02-22 0:08 ` Krzysztof Kozlowski
2016-02-22 3:31 ` Anand Moon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1455858937-2380-1-git-send-email-linux.amoon@gmail.com \
--to=linux.amoon@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jslaby@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=peter@hurleysoftware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).