From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1161904AbcBSJXO (ORCPT ); Fri, 19 Feb 2016 04:23:14 -0500 Received: from mail-pa0-f53.google.com ([209.85.220.53]:32804 "EHLO mail-pa0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1161093AbcBSJXJ (ORCPT ); Fri, 19 Feb 2016 04:23:09 -0500 From: Sudip Mukherjee To: Linus Walleij , Alexandre Courbot Cc: linux-kernel@vger.kernel.org, "Andrew F. Davis" , linux-gpio@vger.kernel.org, Sudip Mukherjee Subject: [PATCH] gpio: pisosr: add missing unlock Date: Fri, 19 Feb 2016 14:53:00 +0530 Message-Id: <1455873780-31935-1-git-send-email-sudipm.mukherjee@gmail.com> X-Mailer: git-send-email 1.9.1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org If spi_read() fails then we just returned but we missed unlocking the mutex. Signed-off-by: Sudip Mukherjee --- drivers/gpio/gpio-pisosr.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/gpio/gpio-pisosr.c b/drivers/gpio/gpio-pisosr.c index 58ea08d..f9f1074 100644 --- a/drivers/gpio/gpio-pisosr.c +++ b/drivers/gpio/gpio-pisosr.c @@ -53,12 +53,10 @@ static int pisosr_gpio_refresh(struct pisosr_gpio *gpio) } ret = spi_read(gpio->spi, gpio->buffer, gpio->buffer_size); - if (ret) - return ret; mutex_unlock(&gpio->lock); - return 0; + return ret; } static int pisosr_gpio_get_direction(struct gpio_chip *chip, -- 1.9.1