From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752844AbcBVCnr (ORCPT <rfc822;w@1wt.eu>);
	Sun, 21 Feb 2016 21:43:47 -0500
Received: from mailgw01.mediatek.com ([218.249.47.110]:52541 "EHLO
	mailgw01.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org
	with ESMTP id S1752582AbcBVCnp (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Sun, 21 Feb 2016 21:43:45 -0500
Message-ID: <1456080189.25237.4.camel@mhfsdcap03>
Subject: Re: [v9,4/5] iommu/mediatek: Add mt8173 IOMMU driver
From: Yong Wu <yong.wu@mediatek.com>
To: Guenter Roeck <linux@roeck-us.net>
CC: Joerg Roedel <joro@8bytes.org>, Thierry Reding <treding@nvidia.com>,
        Mark Rutland <mark.rutland@arm.com>,
        Matthias Brugger <matthias.bgg@gmail.com>, <p.zabel@pengutronix.de>,
        <devicetree@vger.kernel.org>, <pebolle@tiscali.nl>,
        <kendrick.hsu@mediatek.com>, <mitchelh@codeaurora.org>,
        <arnd@arndb.de>, <srv_heupstream@mediatek.com>,
        Catalin Marinas <catalin.marinas@arm.com>,
        Will Deacon <will.deacon@arm.com>, <linux-kernel@vger.kernel.org>,
        Tomasz Figa <tfiga@google.com>, <iommu@lists.linux-foundation.org>,
        Rob Herring <robh+dt@kernel.org>, Daniel Kurtz <djkurtz@google.com>,
        Sasha Hauer <kernel@pengutronix.de>,
        <linux-mediatek@lists.infradead.org>, <youhua.li@mediatek.com>,
        Robin Murphy <robin.murphy@arm.com>,
        <linux-arm-kernel@lists.infradead.org>,
        Lucas Stach <l.stach@pengutronix.de>, <djkurtz@chromium.org>
Date: Mon, 22 Feb 2016 02:43:09 +0800
In-Reply-To: <20160220070209.GA16577@roeck-us.net>
References: <1455669974-1527-5-git-send-email-yong.wu@mediatek.com>
	 <20160220070209.GA16577@roeck-us.net>
Content-Type: text/plain; charset="UTF-8"
X-Mailer: Evolution 3.2.3-0ubuntu6 
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MTK: N
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, 2016-02-19 at 23:02 -0800, Guenter Roeck wrote:
> On Wed, Feb 17, 2016 at 08:46:13AM +0800, Yong Wu wrote:
> > This patch adds support for mediatek m4u (MultiMedia Memory Management
> > Unit).
[...]
> > +#include <linux/clk.h>
> > +#include <linux/component.h>
> > +#include <linux/dma-iommu.h>
> > +#include <linux/interrupt.h>
> > +#include <linux/io.h>
> > +#include <linux/iommu.h>
> > +#include <linux/iopoll.h>
> > +#include <linux/list.h>
> > +#include <linux/module.h>
> > +#include <linux/of_address.h>
> > +#include <linux/of_iommu.h>
> > +#include <linux/of_irq.h>
> > +#include <linux/of_platform.h>
> > +#include <linux/platform_device.h>
> > +#include <soc/mediatek/smi.h>
> > +#include <dt-bindings/memory/mt8173-larb-port.h>
> > +
> 
> Some missing includes:
> 
> linux/bug.h
> 	for WARN_ON()
> linux/device.h
> 	for dev_xxx() error messages, dev_get_drvdata(), etc.
> linux/err.h
> 	for error functions (IS_ERR, error definitions)
> linux/slab.h
> 	for kzalloc() etc.
> linux/spinlock.h
> 	for spinlock functions
> asm/barrier.h
> 	for wmb()
> 
> Guenter

Hi Guenter,
    Thanks for this suggestion. I'm sorry that I didn't get any build
warning or error here. Anyway I will add them and send a quick v10.