From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752651AbcBVAHI (ORCPT ); Sun, 21 Feb 2016 19:07:08 -0500 Received: from smtprelay0079.hostedemail.com ([216.40.44.79]:54127 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752601AbcBVAHE (ORCPT ); Sun, 21 Feb 2016 19:07:04 -0500 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::,RULES_HIT:41:355:379:541:599:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1540:1593:1594:1711:1730:1747:1777:1792:2393:2553:2559:2562:2828:3138:3139:3140:3141:3142:3352:3622:3866:3868:3870:3871:3874:4321:5007:6261:7875:10004:10400:10848:11026:11232:11658:11783:11914:12296:12517:12519:12740:13069:13141:13230:13311:13357:13894:14659:21080:30054:30064:30090:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:1,LUA_SUMMARY:none X-HE-Tag: crook08_56ac143a8f335 X-Filterd-Recvd-Size: 1707 Message-ID: <1456099563.31061.12.camel@perches.com> Subject: Re: [PATCH] Btrfs: ctree: added lines after variable declarations From: Joe Perches To: Philippe Loctaux Cc: jbacik@fb.com, dsterba@suse.com, linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org Date: Sun, 21 Feb 2016 16:06:03 -0800 In-Reply-To: <20160222000107.GA11444@carbon.home> References: <1456098390-9859-1-git-send-email-phil@philippeloctaux.com> <1456098784.31061.10.camel@perches.com> <20160222000107.GA11444@carbon.home> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.18.4-0ubuntu1 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2016-02-22 at 01:01 +0100, Philippe Loctaux wrote: > Is there no need of additional blank line here particulary > or in all lines that I changed? Please don't top post and just here. > On Sun, Feb 21, 2016 at 03:53:04PM -0800, Joe Perches wrote: > > On Mon, 2016-02-22 at 00:46 +0100, Philippe Loctaux wrote: > > > Added lines after variable declarations, fixing 22 checkpatch warnings. > > [] > > > diff --git a/fs/btrfs/ctree.c b/fs/btrfs/ctree.c > > [] > > > @@ -4592,6 +4610,7 @@ void btrfs_truncate_item(struct btrfs_root *root, struct btrfs_path *path, > > >         data_end, old_data_start + new_size - data_end); > > >   } else { > > >   struct btrfs_disk_key disk_key; > > > + > > >   u64 offset; > > > > Overzealous here. > > No additional blank line required.