From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752745AbcBVAy1 (ORCPT ); Sun, 21 Feb 2016 19:54:27 -0500 Received: from mail-lf0-f45.google.com ([209.85.215.45]:34263 "EHLO mail-lf0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752417AbcBVAyZ (ORCPT ); Sun, 21 Feb 2016 19:54:25 -0500 Message-ID: <1456102461.2386.6.camel@gmail.com> Subject: Re: [PATCH v3] net: ethernet: davicom: fix devicetree irq resource From: Sergei Ianovich To: Robert Jarzmik , Francois Romieu , Sergei Shtylyov , "David S. Miller" Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org Date: Mon, 22 Feb 2016 03:54:21 +0300 In-Reply-To: <1456001126-13129-1-git-send-email-robert.jarzmik@free.fr> References: <1456001126-13129-1-git-send-email-robert.jarzmik@free.fr> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.18.3-1 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 2016-02-20 at 21:45 +0100, Robert Jarzmik wrote: > The dm9000 driver doesn't work in at least one device-tree > configuration, spitting an error message on irq resource : > [    1.062495] dm9000 8000000.ethernet: insufficient resources > [    1.068439] dm9000 8000000.ethernet: not found (-2). > [    1.073451] dm9000: probe of 8000000.ethernet failed with error -2 > > The reason behind is that the interrupt might be provided by a gpio > controller, not probed when dm9000 is probed, and needing the probe > deferral mechanism to apply. > > Currently, the interrupt is directly taken from resources. This patch > changes this to use the more generic platform_get_irq(), which > handles > the deferral. > > Moreover, since commit Fixes: 7085a7401ba5 ("drivers: platform: parse > IRQ flags from resources"), the interrupt trigger flags are honored > in > platform_get_irq(), so remove the needless code in dm9000. > > Signed-off-by: Robert Jarzmik > Acked-by: Marcel Ziswiler > Cc: Sergei Shtylyov > Tested-by: Sergei Ianovich I've hit the original bug too. This patch fixes the *regression*. It may be worth adding a note about this. -- Sergei Ianovich