From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1751558AbcBWMBt (ORCPT <rfc822;w@1wt.eu>);
	Tue, 23 Feb 2016 07:01:49 -0500
Received: from mail-lf0-f48.google.com ([209.85.215.48]:34499 "EHLO
	mail-lf0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1750918AbcBWMBr (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 23 Feb 2016 07:01:47 -0500
Message-ID: <1456228901.23036.9.camel@gmail.com>
Subject: Re: [PATCH v1] arm: pxa: fix DT node name for PXA27X usb
From: Sergei Ianovich <ynvich@gmail.com>
To: Robert Jarzmik <robert.jarzmik@free.fr>
Cc: linux-kernel@vger.kernel.org, Daniel Mack <daniel@zonque.org>,
        Haojian Zhuang <haojian.zhuang@gmail.com>,
        Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
        Mark Rutland <mark.rutland@arm.com>,
        Ian Campbell <ijc+devicetree@hellion.org.uk>,
        Kumar Gala <galak@codeaurora.org>,
        Russell King <linux@arm.linux.org.uk>,
        "moderated list:PXA2xx/PXA3xx SUPPORT" 
	<linux-arm-kernel@lists.infradead.org>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
	<devicetree@vger.kernel.org>
Date: Tue, 23 Feb 2016 15:01:41 +0300
In-Reply-To: <87oab8wyfe.fsf@belgarion.home>
References: <1456139297-5854-1-git-send-email-ynvich@gmail.com>
	 <87oab8wyfe.fsf@belgarion.home>
Content-Type: text/plain; charset="UTF-8"
X-Mailer: Evolution 3.18.3-1 
Mime-Version: 1.0
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Robert, 

On Mon, 2016-02-22 at 16:35 +0100, Robert Jarzmik wrote:
> You're right, I haven't seen the pxa2xx.dtsi statement before.
> 
> As such, could you amend a bit your patch please to :
>  - add:
> Fixes: 0ec1939668e5 ("ARM: dts: pxa: add the usb host controller")
>  - make the same change in pxa3xx.dtsi, as the same error is there
>  - and more globally align pxa2xx.dtsi, pxa27x.dtsi and pxa3xx.dtsi
>  - remove the compatible, reg, interrupts and status from both pxa27x.dtsi and
>    pxa3xx.dtsi as they are redundant with the included pxa2xxx.dsti one

No problem. Let's figure out the best approach.

> I'm even wondering if the proper change wouldn't be to scrap the ohci
> declarations from pxa27x.dtsi and pxa3xx.dtsi, and only add the "clocks"
> property to pxa2xx.dtsi ...

Since clocks are declared in pxa27x.dtsi and pxa3xx.dtsi, there is a
stronger ground to have node clocks properties set in pxa27x.dtsi
and pxa3xx.dtsi as well. However, there is already nodes with clocks
properties in pxa2xx.dtsi.

I cannot choose, you should make a decision.


-- 
Sergei Ianovich <ynvich@gmail.com>