From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755240AbcBWUUT (ORCPT ); Tue, 23 Feb 2016 15:20:19 -0500 Received: from host.buserror.net ([209.198.135.123]:54399 "EHLO host.buserror.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752823AbcBWUUR (ORCPT ); Tue, 23 Feb 2016 15:20:17 -0500 Message-ID: <1456258812.5360.22.camel@buserror.net> From: Scott Wood To: Rob Herring , Zhao Qiang Cc: leoyang.li@nxp.com, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linuxppc-dev@lists.ozlabs.org Date: Tue, 23 Feb 2016 14:20:12 -0600 In-Reply-To: <20160223201520.GA3354@rob-hp-laptop> References: <1455757572-44955-1-git-send-email-qiang.zhao@nxp.com> <20160223201520.GA3354@rob-hp-laptop> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.16.5-1ubuntu3.1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 75.72.173.242 X-SA-Exim-Mail-From: oss@buserror.net X-Spam-Report: * -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP * -15 BAYES_00 BODY: Bayes spam probability is 0 to 1% * [score: 0.0000] Subject: Re: [PATCH v2 1/7] QE: Add IC, SI and SIRAM document to device tree bindings. X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:57:07 +0000) X-SA-Exim-Scanned: Yes (on host.buserror.net) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2016-02-23 at 14:15 -0600, Rob Herring wrote: > On Thu, Feb 18, 2016 at 09:06:06AM +0800, Zhao Qiang wrote: > > Add IC, SI and SIRAM document of QE to > > Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/qe.txt > > > > Signed-off-by: Zhao Qiang > > --- > > Changes for v2 > > - Add interrupt-controller in Required properties > > - delete address-cells and size-cells for qe-si and qe-siram > > > > .../devicetree/bindings/powerpc/fsl/cpm_qe/qe.txt | 50 > > ++++++++++++++++++++++ > > 1 file changed, 50 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/qe.txt > > b/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/qe.txt > > index 4f89302..84052a7 100644 > > --- a/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/qe.txt > > +++ b/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/qe.txt > > @@ -69,6 +69,56 @@ Example: > > }; > > }; > > > > +* Interrupt Controller (IC) > > + > > +Required properties: > > +- compatible : should be "fsl,qe-ic". > > > +- compatible : should be "fsl,qe-si". > > > +- compatible : should be "fsl,qe-siram". > > These compatible strings are all a bit generic and should have SoC > specific compatible strings. I don't know about si/siram, but "fsl,qe-ic" has been around since 2008, so it should be documented even if a more specific compatible is also added. -Scott