From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755254AbcBWU1S (ORCPT ); Tue, 23 Feb 2016 15:27:18 -0500 Received: from host.buserror.net ([209.198.135.123]:54429 "EHLO host.buserror.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752579AbcBWU1R (ORCPT ); Tue, 23 Feb 2016 15:27:17 -0500 Message-ID: <1456259233.5360.25.camel@buserror.net> From: Scott Wood To: Rob Herring , Zhao Qiang Cc: leoyang.li@nxp.com, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linuxppc-dev@lists.ozlabs.org Date: Tue, 23 Feb 2016 14:27:13 -0600 In-Reply-To: <20160223202342.GA9008@rob-hp-laptop> References: <1455757572-44955-1-git-send-email-qiang.zhao@nxp.com> <1455757572-44955-3-git-send-email-qiang.zhao@nxp.com> <20160223202342.GA9008@rob-hp-laptop> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.16.5-1ubuntu3.1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 75.72.173.242 X-SA-Exim-Mail-From: oss@buserror.net X-Spam-Report: * -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP * -15 BAYES_00 BODY: Bayes spam probability is 0 to 1% * [score: 0.0000] Subject: Re: [PATCH v2 3/7] QE: Add uqe_serial document to bindings X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:57:07 +0000) X-SA-Exim-Scanned: Yes (on host.buserror.net) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2016-02-23 at 14:23 -0600, Rob Herring wrote: > On Thu, Feb 18, 2016 at 09:06:08AM +0800, Zhao Qiang wrote: > > Add uqe_serial document to > > Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/uqe_serial.txt > > > > Signed-off-by: Zhao Qiang > > --- > > Changes for v2 > > - modify tx/rx-clock-name specification > > > > .../bindings/powerpc/fsl/cpm_qe/uqe_serial.txt | 19 > > +++++++++++++++++++ > > 1 file changed, 19 insertions(+) > > create mode 100644 > > Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/uqe_serial.txt > > > > diff --git > > a/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/uqe_serial.txt > > b/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/uqe_serial.txt > > new file mode 100644 > > index 0000000..436c71c > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/uqe_serial.txt > > @@ -0,0 +1,19 @@ > > +* Serial > > + > > +Currently defined compatibles: > > +- ucc_uart > > + > > +Properties for ucc_uart: > > +port-number : port number of UCC-UART > > How is this used? > > > +tx/rx-clock-name : should be "brg1"-"brg16" for internal clock source, > > + should be "clk1"-"clk28" for external clock source. > > Perhaps you should be using the clock binding here and in other > bindings? These properties are required by the underlying UCC binding (Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/qe/ucc.txt) and predate the clock binding. -Scott