From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S933166AbcBYQK1 (ORCPT <rfc822;w@1wt.eu>);
	Thu, 25 Feb 2016 11:10:27 -0500
Received: from g9t5009.houston.hp.com ([15.240.92.67]:58232 "EHLO
	g9t5009.houston.hp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S932381AbcBYQK0 (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Thu, 25 Feb 2016 11:10:26 -0500
Message-ID: <1456419790.15454.6.camel@hpe.com>
Subject: Re: [PATCH] x86/mm: fix slow_virt_to_phys() for X86_PAE again
From: Toshi Kani <toshi.kani@hpe.com>
To: Dexuan Cui <decui@microsoft.com>, gregkh@linuxfoundation.org,
        akpm@linux-foundation.org, tglx@linutronix.de, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org, driverdev-devel@linuxdriverproject.org,
        jasowang@redhat.com
Cc: olaf@aepfle.de, apw@canonical.com, kys@microsoft.com,
        haiyangz@microsoft.com
Date: Thu, 25 Feb 2016 10:03:10 -0700
In-Reply-To: <1456394292-9030-1-git-send-email-decui@microsoft.com>
References: <1456394292-9030-1-git-send-email-decui@microsoft.com>
Content-Type: text/plain; charset="UTF-8"
X-Mailer: Evolution 3.18.4 (3.18.4-1.fc23) 
Mime-Version: 1.0
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, 2016-02-25 at 01:58 -0800, Dexuan Cui wrote:
> "d1cd12108346: x86, pageattr: Prevent overflow in slow_virt_to_phys() for
> X86_PAE"
> was unintentionally removed by the recent
> "34437e67a672: x86/mm: Fix slow_virt_to_phys() to handle large PAT bit".
> 
> And, the variable 'phys_addr' was defined as "unsigned long" by mistake
> -- it should
> be "phys_addr_t".
> 
> As a result, Hyper-V network driver in 32-PAE Linux guest can't work
> again.
> 
> Fixes: "commmit 34437e67a672: x86/mm: Fix slow_virt_to_phys() to handle
> large PAT bit"
> Signed-off-by: Dexuan Cui <decui@microsoft.com>
> Cc: Toshi Kani <toshi.kani@hpe.com>
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: K. Y. Srinivasan <kys@microsoft.com>
> Cc: Haiyang Zhang <haiyangz@microsoft.com>
> Cc: gregkh@linuxfoundation.org
> Cc: linux-mm@kvack.org
> Cc: olaf@aepfle.de
> Cc: apw@canonical.com
> Cc: jasowang@redhat.com
> Cc: stable@vger.kernel.org

Thanks for the fix and adding the comment to explain the trick!  The change
looks good to me.

Reviewed-by: Toshi Kani <toshi.kani@hpe.com>

-Toshi