From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752637AbcBYXkI (ORCPT ); Thu, 25 Feb 2016 18:40:08 -0500 Received: from mga02.intel.com ([134.134.136.20]:13100 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752447AbcBYXkG (ORCPT ); Thu, 25 Feb 2016 18:40:06 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.22,498,1449561600"; d="scan'208";a="894928049" Message-ID: <1456443514.17628.26.camel@linux.intel.com> Subject: Re: [PATCH 2/2] cpufreq: acpi-cpufreq: Drop pointless label from acpi_cpufreq_target() From: Srinivas Pandruvada To: "Rafael J. Wysocki" , Linux PM list Cc: Linux Kernel Mailing List , Viresh Kumar Date: Thu, 25 Feb 2016 15:38:34 -0800 In-Reply-To: <1905248.5bkSJ3vszA@vostro.rjw.lan> References: <3419119.Zd6aAZrh1K@vostro.rjw.lan> <1905248.5bkSJ3vszA@vostro.rjw.lan> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.18.4 (3.18.4-1.fc23) Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2016-02-26 at 00:03 +0100, Rafael J. Wysocki wrote: > From: Rafael J. Wysocki > > The "out" label at the final return statement in > acpi_cpufreq_target() > is totally pointless, so drop them and modify the code to return the > right values immediately instead of jumping to it. > > No functional changes. > > Signed-off-by: Rafael J. Wysocki Reviewed-by: Srinivas Pandruvada > --- >  drivers/cpufreq/acpi-cpufreq.c |    6 ++---- >  1 file changed, 2 insertions(+), 4 deletions(-) > > Index: linux-pm/drivers/cpufreq/acpi-cpufreq.c > =================================================================== > --- linux-pm.orig/drivers/cpufreq/acpi-cpufreq.c > +++ linux-pm/drivers/cpufreq/acpi-cpufreq.c > @@ -434,7 +434,7 @@ static int acpi_cpufreq_target(struct cp >   } else { >   pr_debug("Already at target state (P%d)\n", >   next_perf_state); > - goto out; > + return 0; >   } >   } >   > @@ -456,8 +456,7 @@ static int acpi_cpufreq_target(struct cp >   cmd.val = (u32) perf- > >states[next_perf_state].control; >   break; >   default: > - result = -ENODEV; > - goto out; > + return -ENODEV; >   } >   >   /* cpufreq holds the hotplug lock, so we are safe from here > on */ > @@ -480,7 +479,6 @@ static int acpi_cpufreq_target(struct cp >   if (!result) >   perf->state = next_perf_state; >   > -out: >   return result; >  } >   > > -- > To unsubscribe from this list: send the line "unsubscribe linux-pm" > in > the body of a message to majordomo@vger.kernel.org > More majordomo info at  http://vger.kernel.org/majordomo-info.html