From: green@linuxhacker.ru
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
devel@driverdev.osuosl.org,
Andreas Dilger <andreas.dilger@intel.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Lustre Development List <lustre-devel@lists.lustre.org>,
Oleg Drokin <green@linuxhacker.ru>
Subject: [PATCH 24/25] staging/lustre: Remove unneeded {} in lprocfs_stats_unlock()
Date: Fri, 26 Feb 2016 01:50:12 -0500 [thread overview]
Message-ID: <1456469413-931943-25-git-send-email-green@linuxhacker.ru> (raw)
In-Reply-To: <1456469413-931943-1-git-send-email-green@linuxhacker.ru>
From: Oleg Drokin <green@linuxhacker.ru>
Since there's only one call in those if () else branches, the
braces are not really necessary.
Highlighted by checkpatch.
Signed-off-by: Oleg Drokin <green@linuxhacker.ru>
---
drivers/staging/lustre/lustre/include/lprocfs_status.h | 10 ++++------
1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/lustre/lustre/include/lprocfs_status.h b/drivers/staging/lustre/lustre/include/lprocfs_status.h
index 89052b2..4146c9c 100644
--- a/drivers/staging/lustre/lustre/include/lprocfs_status.h
+++ b/drivers/staging/lustre/lustre/include/lprocfs_status.h
@@ -426,11 +426,10 @@ static inline void lprocfs_stats_unlock(struct lprocfs_stats *stats, int opc,
case LPROCFS_GET_SMP_ID:
if (stats->ls_flags & LPROCFS_STATS_FLAG_NOPERCPU) {
- if (stats->ls_flags & LPROCFS_STATS_FLAG_IRQ_SAFE) {
+ if (stats->ls_flags & LPROCFS_STATS_FLAG_IRQ_SAFE)
spin_unlock_irqrestore(&stats->ls_lock, *flags);
- } else {
+ else
spin_unlock(&stats->ls_lock);
- }
} else {
put_cpu();
}
@@ -438,11 +437,10 @@ static inline void lprocfs_stats_unlock(struct lprocfs_stats *stats, int opc,
case LPROCFS_GET_NUM_CPU:
if (stats->ls_flags & LPROCFS_STATS_FLAG_NOPERCPU) {
- if (stats->ls_flags & LPROCFS_STATS_FLAG_IRQ_SAFE) {
+ if (stats->ls_flags & LPROCFS_STATS_FLAG_IRQ_SAFE)
spin_unlock_irqrestore(&stats->ls_lock, *flags);
- } else {
+ else
spin_unlock(&stats->ls_lock);
- }
}
return;
}
--
2.1.0
next prev parent reply other threads:[~2016-02-26 6:52 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-26 6:49 [PATCH 00/25] Lustre cleanups continued green
2016-02-26 6:49 ` [PATCH 01/25] staging/lustre/llite: Fix style vs open parenthesis alignment green
2016-02-26 6:49 ` [PATCH 02/25] staging/lustre/include: Fix style of function declarations green
2016-02-26 6:49 ` [PATCH 03/25] staging/lustre/fld: Fix style vs open parenthesis alignment green
2016-02-26 6:49 ` [PATCH 04/25] staging/lustre: Remove unused liblustre_check_services prototype green
2016-02-26 6:49 ` [PATCH 05/25] staging/lustre: Remove unused lustre_build_lock_params() green
2016-02-26 6:49 ` [PATCH 06/25] staging/lustre: Convert ptlrpc_at_check_timed to void green
2016-02-26 6:49 ` [PATCH 07/25] staging/lustre: Remove misleading liblustre comments green
2016-02-26 6:49 ` [PATCH 08/25] staging/lustre: Remove liblustre references from explanations green
2016-02-26 6:49 ` [PATCH 09/25] staging/lustre/lmv: Remove commented out MDS selection policies green
2016-02-26 6:49 ` [PATCH 10/25] staging/lustre: F_SETLKW64 F_SETLK64 F_GETLK64 are always defined green
2016-02-26 6:49 ` [PATCH 11/25] staging/lustre: MS_POSIXACL is always defined, don't check for it green
2016-02-26 6:50 ` [PATCH 12/25] staging/lustre: Remove RELEASEPAGE_ARG_TYPE compat macro green
2016-02-26 6:50 ` [PATCH 13/25] staging/lustre: NEED_QUOTA_DEFS is never defined, drop it green
2016-02-26 6:50 ` [PATCH 14/25] staging/lustre/ptlrpc: Fix style vs open parenthesis alignment green
2016-02-26 6:50 ` [PATCH 15/25] staging/lustre/osc: " green
2016-02-26 6:50 ` [PATCH 16/25] staging/lustre/obdclass: " green
2016-02-26 6:50 ` [PATCH 17/25] staging/lustre/lov: " green
2016-02-26 6:50 ` [PATCH 18/25] staging/lustre/mdc: " green
2016-02-26 6:50 ` [PATCH 19/25] staging/lustre/mgc: " green
2016-02-26 6:50 ` [PATCH 20/25] staging/lustre/obdecho: " green
2016-02-26 6:50 ` [PATCH 21/25] staging/lustre/lmv: " green
2016-02-26 6:50 ` [PATCH 22/25] staging/lustre: Fix lines that start with spaces green
2016-02-26 6:50 ` [PATCH 23/25] staging/lustre: Rework MAX_DIO_SIZE macro green
2016-02-26 6:50 ` green [this message]
2016-02-26 6:50 ` [PATCH 25/25] staging/lustre/ptlrpc: Fix ENABLE_PINGER ifdef green
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1456469413-931943-25-git-send-email-green@linuxhacker.ru \
--to=green@linuxhacker.ru \
--cc=andreas.dilger@intel.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lustre-devel@lists.lustre.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox