From: Chris Bainbridge <chris.bainbridge@gmail.com>
To: bp@alien8.de
Cc: Chris Bainbridge <chris.bainbridge@gmail.com>,
x86@kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH] x86/microcode: Change checksum to u32
Date: Sat, 27 Feb 2016 11:01:47 +0000 [thread overview]
Message-ID: <1456570907-5344-1-git-send-email-chris.bainbridge@gmail.com> (raw)
Checksum should be unsigned 32-bit otherwise the calculation overflows
resulting in undefined behaviour:
[ 0.000000] ================================================================================
[ 0.000000] UBSAN: Undefined behaviour in arch/x86/kernel/cpu/microcode/intel_lib.c:105:12
[ 0.000000] signed integer overflow:
[ 0.000000] -1500151068 + -2125470173 cannot be represented in type 'int'
[ 0.000000] CPU: 0 PID: 0 Comm: swapper Not tainted 4.5.0-rc5+ #495
[ 0.000000] 0000000000000086 0000000000000086 0000000000000000 ffffffff83203968
[ 0.000000] ffffffff81b30952 ffffffff834c43b8 ffffffff83203998 ffffffff814fe623
[ 0.000000] ffffffff83203980 ffffffff81bcdf2d ffffffff8339a448 ffffffff83203a08
[ 0.000000] Call Trace:
[ 0.000000] [<ffffffff81b30952>] dump_stack+0x4e/0x6c
[ 0.000000] [<ffffffff814fe623>] ? inotify_ioctl+0x43/0x1c0
[ 0.000000] [<ffffffff81bcdf2d>] ubsan_epilogue+0xd/0x40
[ 0.000000] [<ffffffff81bce2fd>] handle_overflow+0xbd/0xe0
[ 0.000000] [<ffffffff81bce32e>] __ubsan_handle_add_overflow+0xe/0x10
[ 0.000000] [<ffffffff81148e45>] microcode_sanity_check+0x405/0x590
[ 0.000000] [<ffffffff8549b01b>] get_matching_model_microcode.isra.2.constprop.8+0xa5/0x345
[ 0.000000] [<ffffffff8548615d>] ? early_idt_handler_common+0x3d/0xae
[ 0.000000] [<ffffffff81b50962>] ? strlcpy+0x52/0xa0
[ 0.000000] [<ffffffff81b30ce1>] ? find_cpio_data+0x371/0x510
[ 0.000000] [<ffffffff8549b461>] load_ucode_intel_bsp+0xa1/0xe5
[ 0.000000] [<ffffffff8549aea8>] load_ucode_bsp+0xdf/0xf3
[ 0.000000] [<ffffffff8549aea8>] ? load_ucode_bsp+0xdf/0xf3
[ 0.000000] [<ffffffff8548671c>] x86_64_start_kernel+0xd1/0xee
[ 0.000000] ================================================================================
Signed-off-by: Chris Bainbridge <chris.bainbridge@gmail.com>
---
arch/x86/kernel/cpu/microcode/intel_lib.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/kernel/cpu/microcode/intel_lib.c b/arch/x86/kernel/cpu/microcode/intel_lib.c
index b96896bcbdaf..2bef93ff2e3f 100644
--- a/arch/x86/kernel/cpu/microcode/intel_lib.c
+++ b/arch/x86/kernel/cpu/microcode/intel_lib.c
@@ -49,7 +49,7 @@ int microcode_sanity_check(void *mc, int print_err)
unsigned long total_size, data_size, ext_table_size;
struct microcode_header_intel *mc_header = mc;
struct extended_sigtable *ext_header = NULL;
- int sum, orig_sum, ext_sigcount = 0, i;
+ u32 sum, orig_sum, ext_sigcount = 0, i;
struct extended_signature *ext_sig;
total_size = get_totalsize(mc_header);
--
2.1.4
next reply other threads:[~2016-02-27 11:03 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-27 11:01 Chris Bainbridge [this message]
2016-02-27 17:51 ` [PATCH] x86/microcode: Change checksum to u32 Borislav Petkov
2016-02-27 18:23 ` Chris Bainbridge
2016-02-27 19:44 ` Henrique de Moraes Holschuh
2016-02-27 22:29 ` Borislav Petkov
2016-02-27 20:12 ` Henrique de Moraes Holschuh
2016-03-16 10:52 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1456570907-5344-1-git-send-email-chris.bainbridge@gmail.com \
--to=chris.bainbridge@gmail.com \
--cc=bp@alien8.de \
--cc=linux-kernel@vger.kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox