From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756815AbcB0StE (ORCPT ); Sat, 27 Feb 2016 13:49:04 -0500 Received: from smtprelay0162.hostedemail.com ([216.40.44.162]:43994 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1756618AbcB0StC (ORCPT ); Sat, 27 Feb 2016 13:49:02 -0500 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::,RULES_HIT:41:355:379:541:599:966:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1540:1593:1594:1711:1730:1747:1777:1792:2196:2199:2393:2559:2562:2828:3138:3139:3140:3141:3142:3352:3622:3653:3865:3866:3867:3872:4321:4385:5007:6261:10004:10400:10848:11026:11232:11657:11658:11783:11914:12043:12048:12294:12296:12517:12519:12740:13069:13311:13357:13439:13894:14659:21080:30054:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:2,LUA_SUMMARY:none X-HE-Tag: hall46_88a45650b690f X-Filterd-Recvd-Size: 1802 Message-ID: <1456598936.4436.6.camel@perches.com> Subject: Re: [PATCH] staging: rtl8723au: Fix line longer than 80 columns. From: Joe Perches To: Edward Lipinsky , Larry.Finger@lwfinger.net, Jes.Sorensen@redhat.com, gregkh@linuxfoundation.org Cc: linux-wireless@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Date: Sat, 27 Feb 2016 10:48:56 -0800 In-Reply-To: <20160227182841.GA3387@gmail.com> References: <20160227182841.GA3387@gmail.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.18.5-1ubuntu1 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 2016-02-27 at 10:28 -0800, Edward Lipinsky wrote: > This patch fixes the checkpatch.pl warning: > WARNING: line over 80 characters [] > diff --git a/drivers/staging/rtl8723au/core/rtw_ap.c b/drivers/staging/rtl8723au/core/rtw_ap.c [] > @@ -1834,7 +1834,8 @@ void stop_ap_mode23a(struct rtw_adapter *padapter) >   } >   spin_unlock_bh(&pacl_node_q->lock); >   > - DBG_8723A("%s, free acl_node_queue, num =%d\n", __func__, pacl_list->num); > + DBG_8723A("%s, free acl_node_queue, num =%d\n", __func__, > +   pacl_list->num); It's generally nicer to break the line at the end of the format sting like: DBG_8723A("%s, free acl_node_queue, num =%d\n", __func__, pacl_list->num); though it'd be even better to convert all of these DBG_8723A uses to pr_debug $ git ls-files drivers/staging/rtl8723au/ | \   xargs sed -r -i \ -e 's/\bDBG_8723A\b/pr_debug/g' \   -e 's/\bMSG|8723A\b/pr_debug/g'