From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753473AbcB2KQH (ORCPT ); Mon, 29 Feb 2016 05:16:07 -0500 Received: from mga01.intel.com ([192.55.52.88]:54415 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752119AbcB2KQF (ORCPT ); Mon, 29 Feb 2016 05:16:05 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.22,520,1449561600"; d="scan'208";a="661076801" Message-ID: <1456741007.13244.159.camel@linux.intel.com> Subject: Re: [PATCH v2 1/2] mfd: intel_quark_i2c_gpio: remove clock tree on error path From: Andy Shevchenko To: Stephen Boyd Cc: Lee Jones , linux-kernel@vger.kernel.org, stable@vger.kernel.org Date: Mon, 29 Feb 2016 12:16:47 +0200 In-Reply-To: <20160227005856.GD28849@codeaurora.org> References: <1455871331-93095-1-git-send-email-andriy.shevchenko@linux.intel.com> <20160227005856.GD28849@codeaurora.org> Organization: Intel Finland Oy Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.18.3-1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2016-02-26 at 16:58 -0800, Stephen Boyd wrote: > On 02/19, Andy Shevchenko wrote: > > There is a potential resource leak in case when ->probe() fails. We > > have to > > unregister and remove clock tree which is done here. > > > > This is a follow up to previously pushed commit c4726abce63b ("mfd: > > intel_quark_i2c_gpio: Use clkdev_create()") that prevents double > > free() when > > clkdev_drop() followed by kfree() in devm_kcalloc() release stage. > > > > I leave Fixes tag here, but the backporting will require to > > backport the commit > > c4726abce63b ("mfd: intel_quark_i2c_gpio: Use clkdev_create()") > > first. > > > > Fixes: 60ae5b9f5cdd (mfd: intel_quark_i2c_gpio: Add Intel Quark > > X1000 I2C-GPIO MFD Driver) > > Cc: stable@vger.kernel.org > > Signed-off-by: Andy Shevchenko > > --- > > Both look fine to me. Thanks for review! > You may also want to use > devm_clk_register() instead so that cleanup is easier. Perhaps in the future. -- Andy Shevchenko Intel Finland Oy