From: Yong Wu <yong.wu@mediatek.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Joerg Roedel <jroedel@suse.de>, Joerg Roedel <joro@8bytes.org>,
<linux-arm-kernel@lists.infradead.org>,
Robin Murphy <robin.murphy@arm.com>,
<iommu@lists.linux-foundation.org>,
<linux-mediatek@lists.infradead.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
<linux-kernel@vger.kernel.org>, <srv_heupstream@mediatek.com>
Subject: Re: [PATCH 2/2] iommu/mediatek: mark PM functions as __maybe_unused
Date: Tue, 1 Mar 2016 05:04:19 +0800 [thread overview]
Message-ID: <1456779859.26149.2.camel@mhfsdcap03> (raw)
In-Reply-To: <1456737553-496245-2-git-send-email-arnd@arndb.de>
On Mon, 2016-02-29 at 10:19 +0100, Arnd Bergmann wrote:
> When CONFIG_PM is unset, we get a harmless warning for this driver:
>
> drivers/iommu/mtk_iommu.c:665:12: error: 'mtk_iommu_suspend' defined but not used [-Werror=unused-function]
> drivers/iommu/mtk_iommu.c:680:12: error: 'mtk_iommu_resume' defined but not used [-Werror=unused-function]
>
> Marking the functions as __maybe_unused gits rid of the two functions
> and lets the compiler silently drop the object code, while still
> doing syntax checking on them for build-time verification.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: 0df4fabe208d ("iommu/mediatek: Add mt8173 IOMMU driver")
Hi Arnd,
Thanks very much for both fixes.
next prev parent reply other threads:[~2016-03-01 5:05 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-29 9:19 [PATCH 1/2] iommu/mediatek: select ARM_DMA_USE_IOMMU Arnd Bergmann
2016-02-29 9:19 ` [PATCH 2/2] iommu/mediatek: mark PM functions as __maybe_unused Arnd Bergmann
2016-02-29 21:04 ` Yong Wu [this message]
2016-02-29 10:37 ` [PATCH 1/2] iommu/mediatek: select ARM_DMA_USE_IOMMU Robin Murphy
2016-02-29 10:53 ` Arnd Bergmann
2016-02-29 11:22 ` Robin Murphy
2016-02-29 11:29 ` Arnd Bergmann
2016-02-29 11:47 ` Robin Murphy
2016-02-29 15:48 ` Joerg Roedel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1456779859.26149.2.camel@mhfsdcap03 \
--to=yong.wu@mediatek.com \
--cc=arnd@arndb.de \
--cc=iommu@lists.linux-foundation.org \
--cc=joro@8bytes.org \
--cc=jroedel@suse.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=robin.murphy@arm.com \
--cc=srv_heupstream@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox