From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1750849AbcCAFFL (ORCPT <rfc822;w@1wt.eu>);
	Tue, 1 Mar 2016 00:05:11 -0500
Received: from mailgw02.mediatek.com ([218.249.47.111]:38319 "EHLO
	mailgw02.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org
	with ESMTP id S1750712AbcCAFFK (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 1 Mar 2016 00:05:10 -0500
Message-ID: <1456779859.26149.2.camel@mhfsdcap03>
Subject: Re: [PATCH 2/2] iommu/mediatek: mark PM functions as __maybe_unused
From: Yong Wu <yong.wu@mediatek.com>
To: Arnd Bergmann <arnd@arndb.de>
CC: Joerg Roedel <jroedel@suse.de>, Joerg Roedel <joro@8bytes.org>,
        <linux-arm-kernel@lists.infradead.org>,
        Robin Murphy <robin.murphy@arm.com>,
        <iommu@lists.linux-foundation.org>,
        <linux-mediatek@lists.infradead.org>,
        Matthias Brugger <matthias.bgg@gmail.com>,
        <linux-kernel@vger.kernel.org>, <srv_heupstream@mediatek.com>
Date: Tue, 1 Mar 2016 05:04:19 +0800
In-Reply-To: <1456737553-496245-2-git-send-email-arnd@arndb.de>
References: <1456737553-496245-1-git-send-email-arnd@arndb.de>
	 <1456737553-496245-2-git-send-email-arnd@arndb.de>
Content-Type: text/plain; charset="UTF-8"
X-Mailer: Evolution 3.2.3-0ubuntu6 
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MTK: N
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, 2016-02-29 at 10:19 +0100, Arnd Bergmann wrote:
> When CONFIG_PM is unset, we get a harmless warning for this driver:
> 
> drivers/iommu/mtk_iommu.c:665:12: error: 'mtk_iommu_suspend' defined but not used [-Werror=unused-function]
> drivers/iommu/mtk_iommu.c:680:12: error: 'mtk_iommu_resume' defined but not used [-Werror=unused-function]
> 
> Marking the functions as __maybe_unused gits rid of the two functions
> and lets the compiler silently drop the object code, while still
> doing syntax checking on them for build-time verification.
> 
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: 0df4fabe208d ("iommu/mediatek: Add mt8173 IOMMU driver")

Hi Arnd,
  Thanks very much for both fixes.