From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753403AbcCASbf (ORCPT ); Tue, 1 Mar 2016 13:31:35 -0500 Received: from smtprelay0003.hostedemail.com ([216.40.44.3]:33186 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752769AbcCASbc (ORCPT ); Tue, 1 Mar 2016 13:31:32 -0500 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::,RULES_HIT:41:355:379:541:599:800:960:968:973:982:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1381:1437:1515:1516:1518:1534:1542:1593:1594:1711:1730:1747:1777:1792:2393:2559:2562:2828:2911:3138:3139:3140:3141:3142:3353:3622:3653:3865:3866:3867:3868:3870:3871:3872:3873:4250:4321:4425:5007:6261:7903:8957:9040:10004:10400:10848:11026:11232:11473:11658:11783:11889:11914:12043:12048:12517:12519:12555:12740:13439:13894:14659:21080:30012:30022:30054:30062:30064:30070:30075:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:3,LUA_SUMMARY:none X-HE-Tag: talk10_d1a22f91014f X-Filterd-Recvd-Size: 3365 Message-ID: <1456857088.4436.31.camel@perches.com> Subject: Re: [PATCH] checkpatch.pl: add switch to turn off check for Change-Id From: Joe Perches To: "Pottratz, Dwane" , "apw@canonical.com" , "linux-kernel@vger.kernel.org" , "akpm@linux-foundation.org" Date: Tue, 01 Mar 2016 10:31:28 -0800 In-Reply-To: <575E9C847DA64B429BF50A3C5F8CA3CCA3C3AD05@ORSMSX112.amr.corp.intel.com> References: <575E9C847DA64B429BF50A3C5F8CA3CCA3C3AD05@ORSMSX112.amr.corp.intel.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.18.5-1ubuntu1 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2016-03-01 at 18:26 +0000, Pottratz, Dwane wrote: > A commit hook for the Gerrit code review servers inserts change > identifiers.  These identifiers are noise in the context of the > upstream kernel.  However, they are needed in most development > environments and the error needs to be ignored for static analysis > tools. It looks like there is some tab to space conversion corruption here. Can you please resend it using some other email mechanism? > Signed-off-by: Dwane Pottratz > --- > scripts/checkpatch.pl | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl > index 2b3c228..0756935 100755 > --- a/scripts/checkpatch.pl > +++ b/scripts/checkpatch.pl > @@ -21,6 +21,7 @@ use Getopt::Long qw(:config no_auto_abbrev); > my $quiet = 0; > my $tree = 1; > my $chk_signoff = 1; > +my $chk_changeid = 1; > my $chk_patch = 1; > my $tst_only; > my $emacs = 0; > @@ -64,6 +65,7 @@ Options: >    -q, --quiet                quiet >    --no-tree                  run without a kernel tree >    --no-signoff               do not check for 'Signed-off-by' line > +  --no-changeid              do not check for 'Change-Id' line >    --patch                    treat FILE as patchfile (default) >    --emacs                    emacs compile window format >    --terse                    one line per report > @@ -136,6 +138,7 @@ GetOptions( >                'q|quiet+'            => \$quiet, >                'tree!'                    => \$tree, >                'signoff!'              => \$chk_signoff, > +             'changeid!'          => \$chk_changeid, >                'patch!' => \$chk_patch, >                'emacs!'               => \$emacs, >                'terse!'  => \$terse, > @@ -2310,7 +2313,7 @@ sub process { >                                } >  # Check for unwanted Gerrit info > -                              if ($in_commit_log && $line =~ /^\s*change-id:/i) { > +                             if ($in_commit_log && $line =~ /^\s*change-id:/i && $chk_changeid) { >                                                ERROR("GERRIT_CHANGE_ID", >                                                      "Remove Gerrit Change-Id's before submitting upstream.\n" . $herecurr); >                                } > -- > 1.9.1 >