Re: [PATCH] checkpatch.pl: add switch to turn off check for Change-Id

public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed

* Re: [PATCH] checkpatch.pl: add switch to turn off check for Change-Id
       [not found] <575E9C847DA64B429BF50A3C5F8CA3CCA3C3AD05@ORSMSX112.amr.corp.intel.com>
@ 2016-03-01 18:31 ` Joe Perches
  2016-03-01 18:38   ` Pottratz, Dwane
  0 siblings, 1 reply; 9+ messages in thread
From: Joe Perches @ 2016-03-01 18:31 UTC (permalink / raw)
  To: Pottratz, Dwane, apw@canonical.com, linux-kernel@vger.kernel.org,
	akpm@linux-foundation.org

On Tue, 2016-03-01 at 18:26 +0000, Pottratz, Dwane wrote:
> A commit hook for the Gerrit code review servers inserts change
> identifiers.  These identifiers are noise in the context of the
> upstream kernel.  However, they are needed in most development
> environments and the error needs to be ignored for static analysis
> tools.

It looks like there is some tab to space conversion corruption here.
Can you please resend it using some other email mechanism?

> Signed-off-by: Dwane Pottratz <dwane.pottratz@intel.com>
> ---
> scripts/checkpatch.pl | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index 2b3c228..0756935 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -21,6 +21,7 @@ use Getopt::Long qw(:config no_auto_abbrev);
> my $quiet = 0;
> my $tree = 1;
> my $chk_signoff = 1;
> +my $chk_changeid = 1;
> my $chk_patch = 1;
> my $tst_only;
> my $emacs = 0;
> @@ -64,6 +65,7 @@ Options:
>    -q, --quiet                quiet
>    --no-tree                  run without a kernel tree
>    --no-signoff               do not check for 'Signed-off-by' line
> +  --no-changeid              do not check for 'Change-Id' line
>    --patch                    treat FILE as patchfile (default)
>    --emacs                    emacs compile window format
>    --terse                    one line per report
> @@ -136,6 +138,7 @@ GetOptions(
>                'q|quiet+'            => \$quiet,
>                'tree!'                    => \$tree,
>                'signoff!'              => \$chk_signoff,
> +             'changeid!'          => \$chk_changeid,
>                'patch!' => \$chk_patch,
>                'emacs!'               => \$emacs,
>                'terse!'  => \$terse,
> @@ -2310,7 +2313,7 @@ sub process {
>                                }
>  # Check for unwanted Gerrit info
> -                              if ($in_commit_log && $line =~ /^\s*change-id:/i) {
> +                             if ($in_commit_log && $line =~ /^\s*change-id:/i && $chk_changeid) {
>                                                ERROR("GERRIT_CHANGE_ID",
>                                                      "Remove Gerrit Change-Id's before submitting upstream.\n" . $herecurr);
>                                }
> --
> 1.9.1
> 

^ permalink raw reply	[flat|nested] 9+ messages in thread

* RE: [PATCH] checkpatch.pl: add switch to turn off check for Change-Id
  2016-03-01 18:31 ` [PATCH] checkpatch.pl: add switch to turn off check for Change-Id Joe Perches
@ 2016-03-01 18:38   ` Pottratz, Dwane
  0 siblings, 0 replies; 9+ messages in thread
From: Pottratz, Dwane @ 2016-03-01 18:38 UTC (permalink / raw)
  To: Joe Perches, apw@canonical.com, linux-kernel@vger.kernel.org,
	akpm@linux-foundation.org

Sent in new message as a text file (instead of HTML).  I hope that corrects the issue.

-Dwane


-----Original Message-----
From: Joe Perches [mailto:joe@perches.com] 
Sent: Tuesday, March 1, 2016 10:31 AM
To: Pottratz, Dwane <dwane.pottratz@intel.com>; apw@canonical.com; linux-kernel@vger.kernel.org; akpm@linux-foundation.org
Subject: Re: [PATCH] checkpatch.pl: add switch to turn off check for Change-Id

On Tue, 2016-03-01 at 18:26 +0000, Pottratz, Dwane wrote:
> A commit hook for the Gerrit code review servers inserts change
> identifiers.  These identifiers are noise in the context of the
> upstream kernel.  However, they are needed in most development
> environments and the error needs to be ignored for static analysis
> tools.

It looks like there is some tab to space conversion corruption here.
Can you please resend it using some other email mechanism?

> Signed-off-by: Dwane Pottratz <dwane.pottratz@intel.com>
> ---
> scripts/checkpatch.pl | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index 2b3c228..0756935 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -21,6 +21,7 @@ use Getopt::Long qw(:config no_auto_abbrev);
> my $quiet = 0;
> my $tree = 1;
> my $chk_signoff = 1;
> +my $chk_changeid = 1;
> my $chk_patch = 1;
> my $tst_only;
> my $emacs = 0;
> @@ -64,6 +65,7 @@ Options:
>    -q, --quiet                quiet
>    --no-tree                  run without a kernel tree
>    --no-signoff               do not check for 'Signed-off-by' line
> +  --no-changeid              do not check for 'Change-Id' line
>    --patch                    treat FILE as patchfile (default)
>    --emacs                    emacs compile window format
>    --terse                    one line per report
> @@ -136,6 +138,7 @@ GetOptions(
>                'q|quiet+'            => \$quiet,
>                'tree!'                    => \$tree,
>                'signoff!'              => \$chk_signoff,
> +             'changeid!'          => \$chk_changeid,
>                'patch!' => \$chk_patch,
>                'emacs!'               => \$emacs,
>                'terse!'  => \$terse,
> @@ -2310,7 +2313,7 @@ sub process {
>                                }
>  # Check for unwanted Gerrit info
> -                              if ($in_commit_log && $line =~ /^\s*change-id:/i) {
> +                             if ($in_commit_log && $line =~ /^\s*change-id:/i && $chk_changeid) {
>                                                ERROR("GERRIT_CHANGE_ID",
>                                                      "Remove Gerrit Change-Id's before submitting upstream.\n" . $herecurr);
>                                }
> --
> 1.9.1
> 

^ permalink raw reply	[flat|nested] 9+ messages in thread

* [PATCH] checkpatch.pl: add switch to turn off check for Change-Id
@ 2016-03-01 18:37 Pottratz, Dwane
  2016-03-01 21:41 ` Joe Perches
  0 siblings, 1 reply; 9+ messages in thread
From: Pottratz, Dwane @ 2016-03-01 18:37 UTC (permalink / raw)
  To: apw@canonical.com, joe@perches.com, linux-kernel@vger.kernel.org,
	'akpm@linux-foundation.org'
  Cc: Pottratz, Dwane

A commit hook for the Gerrit code review servers inserts change
identifiers.  These identifiers are noise in the context of the
upstream kernel.  However, they are needed in most development
environments and the error needs to be ignored for static analysis
tools.

Signed-off-by: Dwane Pottratz <dwane.pottratz@intel.com>
---
 scripts/checkpatch.pl | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 2b3c228..0756935 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -21,6 +21,7 @@ use Getopt::Long qw(:config no_auto_abbrev);
 my $quiet = 0;
 my $tree = 1;
 my $chk_signoff = 1;
+my $chk_changeid = 1;
 my $chk_patch = 1;
 my $tst_only;
 my $emacs = 0;
@@ -64,6 +65,7 @@ Options:
   -q, --quiet                quiet
   --no-tree                  run without a kernel tree
   --no-signoff               do not check for 'Signed-off-by' line
+  --no-changeid              do not check for 'Change-Id' line
   --patch                    treat FILE as patchfile (default)
   --emacs                    emacs compile window format
   --terse                    one line per report
@@ -136,6 +138,7 @@ GetOptions(
 	'q|quiet+'	=> \$quiet,
 	'tree!'		=> \$tree,
 	'signoff!'	=> \$chk_signoff,
+	'changeid!'	=> \$chk_changeid,
 	'patch!'	=> \$chk_patch,
 	'emacs!'	=> \$emacs,
 	'terse!'	=> \$terse,
@@ -2310,7 +2313,7 @@ sub process {
 		}
 
 # Check for unwanted Gerrit info
-		if ($in_commit_log && $line =~ /^\s*change-id:/i) {
+		if ($in_commit_log && $line =~ /^\s*change-id:/i && $chk_changeid) {
 			ERROR("GERRIT_CHANGE_ID",
 			      "Remove Gerrit Change-Id's before submitting upstream.\n" . $herecurr);
 		}
-- 
1.9.1

^ permalink raw reply related	[flat|nested] 9+ messages in thread

* Re: [PATCH] checkpatch.pl: add switch to turn off check for Change-Id
  2016-03-01 18:37 Pottratz, Dwane
@ 2016-03-01 21:41 ` Joe Perches
       [not found]   ` <575E9C847DA64B429BF50A3C5F8CA3CCA3C3B13C@ORSMSX112.amr.corp.intel.com>
  0 siblings, 1 reply; 9+ messages in thread
From: Joe Perches @ 2016-03-01 21:41 UTC (permalink / raw)
  To: Pottratz, Dwane, apw@canonical.com, linux-kernel@vger.kernel.org,
	'akpm@linux-foundation.org'

On Tue, 2016-03-01 at 18:37 +0000, Pottratz, Dwane wrote:
> A commit hook for the Gerrit code review servers inserts change
> identifiers.  These identifiers are noise in the context of the
> upstream kernel.  However, they are needed in most development
> environments and the error needs to be ignored for static analysis
> tools.

btw: another way to do this is to use the --ignore <foo-list> option.

$ ./scripts/checkpatch.pl --ignore gerrit_change_id <patch>

^ permalink raw reply	[flat|nested] 9+ messages in thread

[parent not found: <575E9C847DA64B429BF50A3C5F8CA3CCA3C3B13C@ORSMSX112.amr.corp.intel.com>]

* Re: [PATCH] checkpatch.pl: add switch to turn off check for Change-Id
       [not found]   ` <575E9C847DA64B429BF50A3C5F8CA3CCA3C3B13C@ORSMSX112.amr.corp.intel.com>
@ 2016-03-01 23:21     ` Joe Perches
  2016-03-02 19:15       ` Pottratz, Dwane
  0 siblings, 1 reply; 9+ messages in thread
From: Joe Perches @ 2016-03-01 23:21 UTC (permalink / raw)
  To: Pottratz, Dwane; +Cc: Andrew Morton, LKML, Andy Whitcroft

On Tue, 2016-03-01 at 21:49 +0000, Pottratz, Dwane wrote:
> Good to know.  Thx. 

Andrew picked this up, but it might be better to remove your
patch and just use the --ignore option as --ignore is generic
and your patch just duplicates the capability.


> 
> -----Original Message-----
> From: Joe Perches [mailto:joe@perches.com] 
> Sent: Tuesday, March 1, 2016 1:41 PM
> To: Pottratz, Dwane <dwane.pottratz@intel.com>; apw@canonical.com; li
> nux-kernel@vger.kernel.org; 'akpm@linux-foundation.org' <akpm@linux-f
> oundation.org>
> Subject: Re: [PATCH] checkpatch.pl: add switch to turn off check for
> Change-Id
> 
> On Tue, 2016-03-01 at 18:37 +0000, Pottratz, Dwane wrote:
> > 
> > A commit hook for the Gerrit code review servers inserts change 
> > identifiers.  These identifiers are noise in the context of the 
> > upstream kernel.  However, they are needed in most development 
> > environments and the error needs to be ignored for static analysis 
> > tools.
> btw: another way to do this is to use the --ignore <foo-list> option.
> 
> $ ./scripts/checkpatch.pl --ignore gerrit_change_id <patch>
> 

^ permalink raw reply	[flat|nested] 9+ messages in thread

* RE: [PATCH] checkpatch.pl: add switch to turn off check for Change-Id
  2016-03-01 23:21     ` Joe Perches
@ 2016-03-02 19:15       ` Pottratz, Dwane
  2016-03-02 19:19         ` Joe Perches
  0 siblings, 1 reply; 9+ messages in thread
From: Pottratz, Dwane @ 2016-03-02 19:15 UTC (permalink / raw)
  To: Joe Perches; +Cc: Andrew Morton, LKML, Andy Whitcroft

Hi Joe,

Locally I will remove the patch and use the '--ignore' option.  

Is there anything I need to do for upstream?  (Sorry, I am new to submitting patches upstream)

-Dwane

-----Original Message-----
From: Joe Perches [mailto:joe@perches.com] 
Sent: Tuesday, March 1, 2016 3:22 PM
To: Pottratz, Dwane <dwane.pottratz@intel.com>
Cc: Andrew Morton <akpm@linux-foundation.org>; LKML <linux-kernel@vger.kernel.org>; Andy Whitcroft <apw@canonical.com>
Subject: Re: [PATCH] checkpatch.pl: add switch to turn off check for Change-Id

On Tue, 2016-03-01 at 21:49 +0000, Pottratz, Dwane wrote:
> Good to know.  Thx.

Andrew picked this up, but it might be better to remove your patch and just use the --ignore option as --ignore is generic and your patch just duplicates the capability.


> 
> -----Original Message-----
> From: Joe Perches [mailto:joe@perches.com]
> Sent: Tuesday, March 1, 2016 1:41 PM
> To: Pottratz, Dwane <dwane.pottratz@intel.com>; apw@canonical.com; li 
> nux-kernel@vger.kernel.org; 'akpm@linux-foundation.org' <akpm@linux-f 
> oundation.org>
> Subject: Re: [PATCH] checkpatch.pl: add switch to turn off check for 
> Change-Id
> 
> On Tue, 2016-03-01 at 18:37 +0000, Pottratz, Dwane wrote:
> > 
> > A commit hook for the Gerrit code review servers inserts change 
> > identifiers.  These identifiers are noise in the context of the 
> > upstream kernel.  However, they are needed in most development 
> > environments and the error needs to be ignored for static analysis 
> > tools.
> btw: another way to do this is to use the --ignore <foo-list> option.
> 
> $ ./scripts/checkpatch.pl --ignore gerrit_change_id <patch>
> 

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH] checkpatch.pl: add switch to turn off check for Change-Id
  2016-03-02 19:15       ` Pottratz, Dwane
@ 2016-03-02 19:19         ` Joe Perches
  0 siblings, 0 replies; 9+ messages in thread
From: Joe Perches @ 2016-03-02 19:19 UTC (permalink / raw)
  To: Pottratz, Dwane; +Cc: Andrew Morton, LKML, Andy Whitcroft

On Wed, 2016-03-02 at 19:15 +0000, Pottratz, Dwane wrote:
> Hi Joe,

Hello again Dwane.

> Locally I will remove the patch and use the '--ignore' option.  

That's good, thanks.

> Is there anything I need to do for upstream?

No, I think it's fine as-is.

Thanks for the patch, it was fine, but it duplicated
existing functionality.  It just took me a bit to
recognize the duplication.

> (Sorry, I am new to submitting patches upstream)

No worries, and 'welcome'.

cheers, Joe

^ permalink raw reply	[flat|nested] 9+ messages in thread

[parent not found: <1456247448-23968-1-git-send-email-dwane.pottratz@intel.com>]

* RE: [PATCH] checkpatch.pl: add switch to turn off check for Change-Id
       [not found] <1456247448-23968-1-git-send-email-dwane.pottratz@intel.com>
@ 2016-03-01 16:49 ` Pottratz, Dwane
  2016-03-01 17:45   ` Joe Perches
  0 siblings, 1 reply; 9+ messages in thread
From: Pottratz, Dwane @ 2016-03-01 16:49 UTC (permalink / raw)
  To: apw@canonical.com, joe@perches.com, linux-kernel@vger.kernel.org

Was this patch received?  Where can I find the review status of it?

Thanks,
-Dwane

-----Original Message-----
From: Pottratz, Dwane 
Sent: Tuesday, February 23, 2016 9:11 AM
To: apw@canonical.com; joe@perches.com; linux-kernel@vger.kernel.org
Cc: Pottratz, Dwane <dwane.pottratz@intel.com>
Subject: [PATCH] checkpatch.pl: add switch to turn off check for Change-Id

A commit hook for the Gerrit code review servers inserts change indeftifiers.  These identifiers are noise in the context of the upstream kernel.  However, they are needed in most developement environments and the error needs to be ignored for static analysis tools.

Signed-off-by: Dwane Pottratz <dwane.pottratz@intel.com>
---
 scripts/checkpatch.pl | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index 0147c91..7c1f860 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -21,6 +21,7 @@ use Getopt::Long qw(:config no_auto_abbrev);  my $quiet = 0;  my $tree = 1;  my $chk_signoff = 1;
+my $chk_changeid = 1;
 my $chk_patch = 1;
 my $tst_only;
 my $emacs = 0;
@@ -64,6 +65,7 @@ Options:
   -q, --quiet                quiet
   --no-tree                  run without a kernel tree
   --no-signoff               do not check for 'Signed-off-by' line
+  --no-changeid              do not check for 'Change-Id' line
   --patch                    treat FILE as patchfile (default)
   --emacs                    emacs compile window format
   --terse                    one line per report
@@ -136,6 +138,7 @@ GetOptions(
 	'q|quiet+'	=> \$quiet,
 	'tree!'		=> \$tree,
 	'signoff!'	=> \$chk_signoff,
+	'changeid!'	=> \$chk_changeid,
 	'patch!'	=> \$chk_patch,
 	'emacs!'	=> \$emacs,
 	'terse!'	=> \$terse,
@@ -2332,7 +2335,7 @@ sub process {
 		}
 
 # Check for unwanted Gerrit info
-		if ($in_commit_log && $line =~ /^\s*change-id:/i) {
+		if ($in_commit_log && $line =~ /^\s*change-id:/i && $chk_changeid) {
 			ERROR("GERRIT_CHANGE_ID",
 			      "Remove Gerrit Change-Id's before submitting upstream.\n" . $herecurr);
 		}
--
1.9.1

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH] checkpatch.pl: add switch to turn off check for Change-Id
  2016-03-01 16:49 ` Pottratz, Dwane
@ 2016-03-01 17:45   ` Joe Perches
  0 siblings, 0 replies; 9+ messages in thread
From: Joe Perches @ 2016-03-01 17:45 UTC (permalink / raw)
  To: Pottratz, Dwane, apw@canonical.com, linux-kernel@vger.kernel.org
  Cc: Andrew Morton

On Tue, 2016-03-01 at 16:49 +0000, Pottratz, Dwane wrote:
> Was this patch received?  Where can I find the review status of it?

I don't recall seeing it before, but it seems sensible enough.

> Thanks,
> -Dwane
> 
> -----Original Message-----
> From: Pottratz, Dwane 
> Sent: Tuesday, February 23, 2016 9:11 AM
> To: apw@canonical.com; joe@perches.com; linux-kernel@vger.kernel.org
> Cc: Pottratz, Dwane <dwane.pottratz@intel.com>
> Subject: [PATCH] checkpatch.pl: add switch to turn off check for Change-Id
> 
> A commit hook for the Gerrit code review servers inserts change indeftifiers.  These identifiers are noise in the context of the upstream kernel.  However, they are needed in most developement environments and the error needs to be ignored for static analysis tools.
> 
> Signed-off-by: Dwane Pottratz <dwane.pottratz@intel.com>
> ---
>  scripts/checkpatch.pl | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index 0147c91..7c1f860 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -21,6 +21,7 @@ use Getopt::Long qw(:config no_auto_abbrev);  my $quiet = 0;  my $tree = 1;  my $chk_signoff = 1;
> +my $chk_changeid = 1;
>  my $chk_patch = 1;
>  my $tst_only;
>  my $emacs = 0;
> @@ -64,6 +65,7 @@ Options:
>    -q, --quiet                quiet
>    --no-tree                  run without a kernel tree
>    --no-signoff               do not check for 'Signed-off-by' line
> +  --no-changeid              do not check for 'Change-Id' line
>    --patch                    treat FILE as patchfile (default)
>    --emacs                    emacs compile window format
>    --terse                    one line per report
> @@ -136,6 +138,7 @@ GetOptions(
>  	'q|quiet+'	=> \$quiet,
>  	'tree!'		=> \$tree,
>  	'signoff!'	=> \$chk_signoff,
> +	'changeid!'	=> \$chk_changeid,
>  	'patch!'	=> \$chk_patch,
>  	'emacs!'	=> \$emacs,
>  	'terse!'	=> \$terse,
> @@ -2332,7 +2335,7 @@ sub process {
>  		}
>  
>  # Check for unwanted Gerrit info
> -		if ($in_commit_log && $line =~ /^\s*change-id:/i) {
> +		if ($in_commit_log && $line =~ /^\s*change-id:/i && $chk_changeid) {
>  			ERROR("GERRIT_CHANGE_ID",
>  			      "Remove Gerrit Change-Id's before submitting upstream.\n" . $herecurr);
>  		}
> --
> 1.9.1
> 

^ permalink raw reply	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2016-03-02 19:19 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <575E9C847DA64B429BF50A3C5F8CA3CCA3C3AD05@ORSMSX112.amr.corp.intel.com>
2016-03-01 18:31 ` [PATCH] checkpatch.pl: add switch to turn off check for Change-Id Joe Perches
2016-03-01 18:38   ` Pottratz, Dwane
2016-03-01 18:37 Pottratz, Dwane
2016-03-01 21:41 ` Joe Perches
     [not found]   ` <575E9C847DA64B429BF50A3C5F8CA3CCA3C3B13C@ORSMSX112.amr.corp.intel.com>
2016-03-01 23:21     ` Joe Perches
2016-03-02 19:15       ` Pottratz, Dwane
2016-03-02 19:19         ` Joe Perches
     [not found] <1456247448-23968-1-git-send-email-dwane.pottratz@intel.com>
2016-03-01 16:49 ` Pottratz, Dwane
2016-03-01 17:45   ` Joe Perches

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox