From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752840AbcCAXVy (ORCPT ); Tue, 1 Mar 2016 18:21:54 -0500 Received: from smtprelay0143.hostedemail.com ([216.40.44.143]:50476 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752103AbcCAXVw (ORCPT ); Tue, 1 Mar 2016 18:21:52 -0500 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::,RULES_HIT:41:355:379:541:599:800:960:968:973:982:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1431:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:1981:2194:2199:2393:2551:2553:2559:2562:2828:2911:3138:3139:3140:3141:3142:3352:3622:3865:3866:3867:3868:3870:3871:3872:4321:4425:5007:6261:7576:7974:9010:9545:10004:10400:10848:11026:11232:11658:11783:11914:12050:12517:12519:12740:13069:13095:13311:13357:13436:13439:13894:14659:21080:21325:30012:30054:30063:30064:30070:30090:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:3,LUA_SUMMARY:none X-HE-Tag: dog43_4a2996ad8d83f X-Filterd-Recvd-Size: 2162 Message-ID: <1456874508.4436.39.camel@perches.com> Subject: Re: [PATCH] checkpatch.pl: add switch to turn off check for Change-Id From: Joe Perches To: "Pottratz, Dwane" Cc: Andrew Morton , LKML , Andy Whitcroft Date: Tue, 01 Mar 2016 15:21:48 -0800 In-Reply-To: <575E9C847DA64B429BF50A3C5F8CA3CCA3C3B13C@ORSMSX112.amr.corp.intel.com> References: <575E9C847DA64B429BF50A3C5F8CA3CCA3C3AD52@ORSMSX112.amr.corp.intel.com> <1456868479.4436.37.camel@perches.com> <575E9C847DA64B429BF50A3C5F8CA3CCA3C3B13C@ORSMSX112.amr.corp.intel.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.18.5-1ubuntu1 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2016-03-01 at 21:49 +0000, Pottratz, Dwane wrote: > Good to know.  Thx.  Andrew picked this up, but it might be better to remove your patch and just use the --ignore option as --ignore is generic and your patch just duplicates the capability. > > -----Original Message----- > From: Joe Perches [mailto:joe@perches.com]  > Sent: Tuesday, March 1, 2016 1:41 PM > To: Pottratz, Dwane ; apw@canonical.com; li > nux-kernel@vger.kernel.org; 'akpm@linux-foundation.org' oundation.org> > Subject: Re: [PATCH] checkpatch.pl: add switch to turn off check for > Change-Id > > On Tue, 2016-03-01 at 18:37 +0000, Pottratz, Dwane wrote: > > > > A commit hook for the Gerrit code review servers inserts change  > > identifiers.  These identifiers are noise in the context of the  > > upstream kernel.  However, they are needed in most development  > > environments and the error needs to be ignored for static analysis  > > tools. > btw: another way to do this is to use the --ignore option. > > $ ./scripts/checkpatch.pl --ignore gerrit_change_id >