From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755577AbcCCDzg (ORCPT ); Wed, 2 Mar 2016 22:55:36 -0500 Received: from smtprelay0246.hostedemail.com ([216.40.44.246]:59360 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753549AbcCCDze (ORCPT ); Wed, 2 Mar 2016 22:55:34 -0500 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::::::::::::::::::,RULES_HIT:41:152:355:379:541:599:960:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1539:1593:1594:1711:1730:1747:1777:1792:2393:2559:2562:2827:3138:3139:3140:3141:3142:3352:3622:3865:3866:3867:3870:3872:3873:4321:5007:6261:10004:10400:10848:11232:11658:11783:11914:12043:12048:12295:12296:12438:12517:12519:12534:12679:12740:13069:13311:13357:13894:14659:21060:21080:30054:30079:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:2,LUA_SUMMARY:none X-HE-Tag: songs82_30023031fb32e X-Filterd-Recvd-Size: 2392 Message-ID: <1456977328.4044.99.camel@perches.com> Subject: Re: [PATCH] driver: input :touchscreen : add Raydium I2C touch driver From: Joe Perches To: Jeffrey Lin =?UTF-8?Q?=28=E6=9E=97=E7=BE=A9=E7=AB=A0=29?= , "jeffrey.lin" , "dmitry.torokhov@gmail.com" , "rydberg@euromail.se" , "grant.likely@linaro.org" , "robh+dt@kernel.org" , "jeesw@melfas.com" , "bleung@chromium.org" , "scott.liu@emc.com.tw" Cc: Roger Yang =?UTF-8?Q?=28=E6=A5=8A=E9=8E=AE=E7=91=8B=29?= , KP Li =?UTF-8?Q?=28=E6=9D=8E=E6=98=86=E5=80=8D=29?= , Albert Shieh =?UTF-8?Q?=28=E8=AC=9D=E6=AC=A3=E7=91=8B=29?= , "linux-kernel@vger.kernel.org" , "linux-input@vger.kernel.org" , "devicetree@vger.kernel.org" Date: Wed, 02 Mar 2016 19:55:28 -0800 In-Reply-To: <9BE4B49389AB2F41A64A32DFC844F1DF73EF8627@RADHCMS5.corp.rad-ic.com> References: <1456972150-32303-1-git-send-email-jeffrey.lin@rad-ic.com> <1456973050.4044.81.camel@perches.com> <9BE4B49389AB2F41A64A32DFC844F1DF73EF8627@RADHCMS5.corp.rad-ic.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.18.5-1ubuntu1 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2016-03-03 at 03:14 +0000, Jeffrey Lin (林義章) wrote: > Hi Joe: > Thank you for your response. I'll follow your comments in next version. OK, btw: the below looks very odd > > +static int raydium_i2c_send_message(struct i2c_client *client, > > + size_t len, void *data) > > +{ > > + int error; > > + u8 buf[HEADER_SIZE], ii; > > + > > + for (ii = 0; ii < HEADER_SIZE; ii++) > > + buf[ii] = ((u8 *)data)[3 - ii]; It intermixes a #define of 4 with a hard declaration of 3 to reverse copy a byte array of length HEADER_SIZE. Maybe use: for (ii = 0; ii < HEADER_SIZE; ii++) buf[ii] = ((u8 *)data)[HEADER_SIZE - 1 - ii]