From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760607AbcCEAZO (ORCPT ); Fri, 4 Mar 2016 19:25:14 -0500 Received: from smtprelay0115.hostedemail.com ([216.40.44.115]:41437 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1760332AbcCEAZM (ORCPT ); Fri, 4 Mar 2016 19:25:12 -0500 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::,RULES_HIT:41:355:379:541:599:800:960:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1431:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2393:2559:2562:2689:2828:2914:3138:3139:3140:3141:3142:3353:3622:3865:3866:3867:3870:3871:3873:3874:4321:5007:6119:6261:7903:10004:10400:10848:11026:11232:11657:11658:11783:11914:12043:12296:12438:12517:12519:12555:12740:13069:13311:13357:13439:13894:14659:14721:21080:30054:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:1,LUA_SUMMARY:none X-HE-Tag: wheel65_4a2455e9a7d4b X-Filterd-Recvd-Size: 2779 Message-ID: <1457137507.4044.143.camel@perches.com> Subject: Re: [PATCH] cxgbit: fix dma_addr_t printk format From: Joe Perches To: Arnd Bergmann , "Nicholas A. Bellinger" Cc: Varun Prakash , linux-scsi@vger.kernel.org, target-devel@vger.kernel.org, linux-kernel@vger.kernel.org Date: Fri, 04 Mar 2016 16:25:07 -0800 In-Reply-To: <1457136294-2229829-1-git-send-email-arnd@arndb.de> References: <1457136294-2229829-1-git-send-email-arnd@arndb.de> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.18.5-1ubuntu1 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 2016-03-05 at 01:04 +0100, Arnd Bergmann wrote: > The newly added driver prints a dma_addr_t using the %llx format string, > but that is wrong on most 32-bit architectures: > > drivers/target/iscsi/cxgbit/cxgbit_ddp.c: In function 'cxgbit_dump_sgl': > drivers/target/iscsi/cxgbit/cxgbit_ddp.c:180:10: error: format '%llx' expects argument of type 'long long unsigned int', but argument 8 has type 'dma_addr_t {aka unsigned int}' [-Werror=format=] >    pr_info("\t%d/%u, 0x%p: len %u, off %u, pg 0x%p, dma 0x%llx, %u\n", > > Unfortunately, we can't use the %pad format string here because > we are not printing an lvalue, so we have to add a cast to u64, which > matches the format string on all architectures. > Signed-off-by: Arnd Bergmann > Fixes: c49aa56e556d ("cxgbit: add cxgbit_ddp.c") > --- >  drivers/target/iscsi/cxgbit/cxgbit_ddp.c | 2 +- >  1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/target/iscsi/cxgbit/cxgbit_ddp.c b/drivers/target/iscsi/cxgbit/cxgbit_ddp.c > index 07e2bc86d0df..d667bc88e21d 100644 > --- a/drivers/target/iscsi/cxgbit/cxgbit_ddp.c > +++ b/drivers/target/iscsi/cxgbit/cxgbit_ddp.c > @@ -179,7 +179,7 @@ cxgbit_dump_sgl(const char *cap, struct scatterlist *sgl, int nents) >   for_each_sg(sgl, sg, nents, i) >   pr_info("\t%d/%u, 0x%p: len %u, off %u, pg 0x%p, dma 0x%llx, %u\n", >   i, nents, sg, sg->length, sg->offset, sg_page(sg), > - sg_dma_address(sg), sg_dma_len(sg)); > + (u64)sg_dma_address(sg), sg_dma_len(sg)); >  } >   >  static int cxgbit_ddp_sgl_check(struct scatterlist *sgl, int nents) You could create a temporary:   for_each_sg(sgl, sg, nents, i) { dma_addr_t addr = sg_dma_address(sg); pr_info("\t%d/%u, 0x%p: len %u, off %u, pg 0x%p, dma %pad, %u\n", i, nents, sg, sg->length, sg->offset, sg_page(sg), &addr, sg_dma_len(sg)); } >