From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760233AbcCECUb (ORCPT ); Fri, 4 Mar 2016 21:20:31 -0500 Received: from smtprelay0178.hostedemail.com ([216.40.44.178]:38852 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1759709AbcCECUa (ORCPT ); Fri, 4 Mar 2016 21:20:30 -0500 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::,RULES_HIT:41:355:379:541:599:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2393:2551:2553:2559:2562:2828:2914:3138:3139:3140:3141:3142:3352:3622:3865:3868:3870:3871:3873:4321:5007:6119:6261:7903:10004:10400:10848:11026:11232:11657:11658:11783:11914:12043:12050:12517:12519:12740:13069:13311:13357:13439:13894:14659:14721:21080:30054:30090:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:1,LUA_SUMMARY:none X-HE-Tag: pain55_3e2cf260f0f5c X-Filterd-Recvd-Size: 2126 Message-ID: <1457144425.4044.147.camel@perches.com> Subject: Re: [PATCH] cxgbit: fix dma_addr_t printk format From: Joe Perches To: Arnd Bergmann Cc: "Nicholas A. Bellinger" , Varun Prakash , linux-scsi@vger.kernel.org, target-devel@vger.kernel.org, linux-kernel@vger.kernel.org Date: Fri, 04 Mar 2016 18:20:25 -0800 In-Reply-To: <1512908.OAtrKYf46L@wuerfel> References: <1457136294-2229829-1-git-send-email-arnd@arndb.de> <1457137507.4044.143.camel@perches.com> <1512908.OAtrKYf46L@wuerfel> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.18.5-1ubuntu1 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 2016-03-05 at 01:34 +0100, Arnd Bergmann wrote: > On Friday 04 March 2016 16:25:07 Joe Perches wrote: > > > diff --git a/drivers/target/iscsi/cxgbit/cxgbit_ddp.c b/drivers/target/iscsi/cxgbit/cxgbit_ddp.c [] > > > @@ -179,7 +179,7 @@ cxgbit_dump_sgl(const char *cap, struct scatterlist *sgl, int nents) > > >       for_each_sg(sgl, sg, nents, i) > > >               pr_info("\t%d/%u, 0x%p: len %u, off %u, pg 0x%p, dma 0x%llx, %u\n", > > >                       i, nents, sg, sg->length, sg->offset, sg_page(sg), > > > -                     sg_dma_address(sg), sg_dma_len(sg)); > > > +                     (u64)sg_dma_address(sg), sg_dma_len(sg)); [] > > You could create a temporary:         for_each_sg(sgl, sg, nents, i) {                 dma_addr_t addr = sg_dma_address(sg);                 pr_info("\t%d/%u, 0x%p: len %u, off %u, pg 0x%p, dma %pad, %u\n",                         i, nents, sg, sg->length, sg->offset, sg_page(sg),                         &addr, sg_dma_len(sg));         } Sure, but the cast seemed nicer in this case, the result is the same. Not quite as 0x%llx isn't always the same width and doesn't have leading 0's like %pad