From: Benjamin Tissoires <benjamin.tissoires@redhat.com>
To: Jiri Kosina <jikos@kernel.org>, linux-input@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH] HID: multitouch: force retrieving of Win8 signature blob
Date: Mon, 7 Mar 2016 11:02:38 +0100 [thread overview]
Message-ID: <1457344958-9987-1-git-send-email-benjamin.tissoires@redhat.com> (raw)
The Synaptics 0x11e5 over I2C found in the Asus T100-CHI requires to
fetch the signature blob to actually start sending events.
With this patch, we should be close enough to the Windows driver which
checks the content of the blob at plugin to validate or not the
touchscreen.
Fixes: https://bugzilla.kernel.org/show_bug.cgi?id=113481
regression introduced by 6d4f5440 ("HID: multitouch: Fetch feature
reports on demand for Win8 devices") which has been backported to stable.
Cc: stable@vger.kernel.org
Signed-off-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
---
Hi Jiri,
Let's hope this will be the final patch for Win8 touch devices. I do not
think we need much more tests from broader devices as this is really what
we use to do before 6d4f5440, and this is also what the Windows driver does.
Crossing fingers.
Cheers,
Benjamin
drivers/hid/hid-multitouch.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/drivers/hid/hid-multitouch.c b/drivers/hid/hid-multitouch.c
index 6adb788..c2cb46d 100644
--- a/drivers/hid/hid-multitouch.c
+++ b/drivers/hid/hid-multitouch.c
@@ -396,6 +396,11 @@ static void mt_feature_mapping(struct hid_device *hdev,
td->is_buttonpad = true;
break;
+ case 0xff0000c5:
+ /* Retrieve the Win8 blob once to enable some devices */
+ if (usage->usage_index == 0)
+ mt_get_feature(hdev, field->report);
+ break;
}
}
--
2.5.0
next reply other threads:[~2016-03-07 10:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-07 10:02 Benjamin Tissoires [this message]
2016-03-07 22:45 ` [PATCH] HID: multitouch: force retrieving of Win8 signature blob Jiri Kosina
2016-03-08 7:43 ` Benjamin Tissoires
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1457344958-9987-1-git-send-email-benjamin.tissoires@redhat.com \
--to=benjamin.tissoires@redhat.com \
--cc=jikos@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).