From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933344AbcCIRDi (ORCPT ); Wed, 9 Mar 2016 12:03:38 -0500 Received: from slow1-d.mail.gandi.net ([217.70.178.86]:39719 "EHLO slow1-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932397AbcCIRD2 (ORCPT ); Wed, 9 Mar 2016 12:03:28 -0500 X-Originating-IP: 83.155.44.161 Message-ID: <1457542738.2648.113.camel@hadess.net> Subject: Re: [PATCH] hid: sony: Add power supply support for PS3 remote From: Bastien Nocera To: Frederic Jacob , jikos@kernel.org Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Date: Wed, 09 Mar 2016 17:58:58 +0100 In-Reply-To: <1457487659-3970-1-git-send-email-frederic.jacob.78@gmail.com> References: <1457487659-3970-1-git-send-email-frederic.jacob.78@gmail.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.18.5.1 (3.18.5.1-1.fc23) Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hey Frederic, On Tue, 2016-03-08 at 20:40 -0500, Frederic Jacob wrote: > Add power supply support for the PS3 remote controller Isn't something like "add battery state reporting for PS3 remotes" better? Also, as I don't think it's physically possible to have the PS3 remote both connected and charging at the same time, maybe the comment in sixaxis_parse_report() should be modified to make it clear that the PS3 remote doesn't have that problem. Cheers