From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754511AbcCJILJ (ORCPT ); Thu, 10 Mar 2016 03:11:09 -0500 Received: from mga04.intel.com ([192.55.52.120]:56324 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751711AbcCJILF (ORCPT ); Thu, 10 Mar 2016 03:11:05 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,314,1455004800"; d="scan'208";a="920771518" Message-ID: <1457597509.1347.49.camel@linux.intel.com> Subject: Re: [patch net 1/2] net: hns: fix return value of the function about rss From: Andy Shevchenko To: Kejian Yan , davem@davemloft.net Cc: yisen.zhuang@huawei.com, salil.mehta@huawei.com, liguozhu@huawei.com, huangdaode@hisilicon.com, arnd@arndb.de, andrew@lunn.ch, chenny.xu@huawei.com, ivecera@redhat.com, lisheng011@huawei.com, fengguang.wu@intel.com, haifeng.wei@huawei.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linuxarm@huawei.com Date: Thu, 10 Mar 2016 10:11:49 +0200 In-Reply-To: <1457576189-22924-2-git-send-email-yankejian@huawei.com> References: <1457576189-22924-1-git-send-email-yankejian@huawei.com> <1457576189-22924-2-git-send-email-yankejian@huawei.com> Organization: Intel Finland Oy Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.18.5.1-1 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2016-03-10 at 10:16 +0800, Kejian Yan wrote: > Both .get_rxfh and .get_rxfh are always return 0, it should return > result > from hardware when getting or setting rss. And the rss function > should > return the correct data type. > @@ -1213,7 +1213,7 @@ hns_get_rss(struct net_device *netdev, u32 > *indir, u8 *key, u8 *hfunc) >   > >   ret = ops->get_rss(priv->ae_handle, indir, key, hfunc); >   > - return 0; > + return ret; All three can be one line. > @@ -1241,7 +1241,7 @@ hns_set_rss(struct net_device *netdev, const > u32 *indir, const u8 *key, >   >   ret = ops->set_rss(priv->ae_handle, indir, key, hfunc); >   > - return 0; > + return ret; Ditto. -- Andy Shevchenko Intel Finland Oy