From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752842AbcCJTIR (ORCPT ); Thu, 10 Mar 2016 14:08:17 -0500 Received: from smtprelay0201.hostedemail.com ([216.40.44.201]:42200 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750942AbcCJTIG (ORCPT ); Thu, 10 Mar 2016 14:08:06 -0500 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 50,0,0,,d41d8cd98f00b204,joe@perches.com,:::::,RULES_HIT:41:355:379:541:599:901:966:967:968:973:982:988:989:1042:1260:1263:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2110:2196:2198:2199:2200:2393:2525:2553:2561:2564:2682:2685:2693:2828:2859:2933:2937:2939:2942:2945:2947:2951:2954:3022:3138:3139:3140:3141:3142:3353:3622:3698:3865:3866:3867:3868:3870:3871:3872:3934:3936:3938:3941:3944:3947:3950:3953:3956:3959:4250:4321:4362:4385:5007:6119:6120:6261:7901:7903:9025:9388:10004:10049:10400:10848:11232:11658:11783:11914:12043:12517:12519:12555:12663:12740:13069:13071:13311:13357:13437:13439:13894:14094:14659:14721:21060:21067:21080:30003:30054:30070:30079:30090:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:2,LUA_SUMMARY:none X-HE-Tag: hill17_804479a59e140 X-Filterd-Recvd-Size: 2092 Message-ID: <1457636880.3433.12.camel@perches.com> Subject: Re: checkpatch.pl false positive: FSF mailing address From: Joe Perches To: Brian Norris Cc: linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org Date: Thu, 10 Mar 2016 11:08:00 -0800 In-Reply-To: <20160310190023.GB2545@google.com> References: <20160310190023.GB2545@google.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.18.5.1-1ubuntu1 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2016-03-10 at 11:00 -0800, Brian Norris wrote: > Hi Joe, Hi Brian. > I found this false positive amusing: > > $ curl http://patchwork.ozlabs.org/patch/577786/mbox/ | scripts/checkpatch.pl - > [...] > ERROR: Do not include the paragraph about writing to the Free Software > Foundation's mailing address from the sample GPL notice. The FSF has > changed addresses in the past, and may do so again. Linux already > includes a copy of the GPL. > #1489: FILE: drivers/mtd/nand/qcom_nandc.c:1335: > +^I^I * write to the free oob area.$ > [...] > > The patch is: >   http://patchwork.ozlabs.org/patch/577786/ >   [PATCH v8,2/3] mtd: nand: Qualcomm NAND controller driver > > and the comment text is: > >   "For the last codeword, we skip the bbm positions and write to the >   free oob area." > > which matches on this: > > # Check for FSF mailing addresses. >                 if ($rawline =~ /\bwrite to the Free/i || > > I'm just writing as recommended by the closing text of your tool. Thanks. Yeah, it's amusing.  It's also likely not something worth bothering with though as the likelihood of fixing it is low and eventually the FSF warning will be minimized or removed as no longer necessary. checkpatch is stupid, false positives will always exist. cheers, Joe