From: Joe Perches <joe@perches.com>
To: Ravishankar Karkala Mallikarjunayya <ravishankarkm32@gmail.com>,
abbotti@mev.co.uk
Cc: hsweeten@visionengravers.com, gregkh@linuxfoundation.org,
geliangtang@163.com, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 5/5] Staging: comedi: Fix type issue in ni_tio.c
Date: Mon, 14 Mar 2016 07:39:03 -0700 [thread overview]
Message-ID: <1457966343.11972.94.camel@perches.com> (raw)
In-Reply-To: <1457953584-31304-5-git-send-email-ravishankarkm32@gmail.com>
On Mon, 2016-03-14 at 16:36 +0530, Ravishankar Karkala Mallikarjunayya wrote:
> This is a patch to the ni_tio.c file that fixes up a type issues
> found by the checkpatch.pl tool.
> i.e. Prefer kernel type 'u64' over 'uint64_t'
[]
> diff --git a/drivers/staging/comedi/drivers/ni_tio.c b/drivers/staging/comedi/drivers/ni_tio.c
[]
> @@ -189,7 +189,7 @@ static void ni_tio_reset_count_and_disarm(struct ni_gpct *counter)
> static uint64_t ni_tio_clock_period_ps(const struct ni_gpct *counter,
> unsigned generic_clock_source)
> {
> - uint64_t clock_period_ps;
> + u64 clock_period_ps;
Please don't blinkeredly fix checkpatch messages.
Understand the code, not just the checkpatch output.
This function returns a uint64_t, maybe it should be
converted to u64 as well.
next prev parent reply other threads:[~2016-03-14 14:39 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-14 11:06 [PATCH 1/5] Staging: comedi: Fix type issues in s626.c Ravishankar Karkala Mallikarjunayya
2016-03-14 11:06 ` [PATCH 2/5] Staging: comedi: Fix Block comment " Ravishankar Karkala Mallikarjunayya
2016-03-14 11:06 ` [PATCH 3/5] Staging: comedi: Fix WARNING issue " Ravishankar Karkala Mallikarjunayya
2016-03-14 11:06 ` [PATCH 4/5] Staging: comedi: fix CHECK issue in ni_tio.c Ravishankar Karkala Mallikarjunayya
2016-03-14 11:06 ` [PATCH 5/5] Staging: comedi: Fix type " Ravishankar Karkala Mallikarjunayya
2016-03-14 14:39 ` Joe Perches [this message]
2016-03-14 15:03 ` [PATCH 1/5] Staging: comedi: Fix type issues in s626.c Ian Abbott
-- strict thread matches above, loose matches on Subject: below --
2016-03-10 6:52 [PATCH 1/5] Staging: comedi: fix type issue " Ravishankar Karkala Mallikarjunayya
2016-03-10 6:52 ` [PATCH 5/5] Staging: comedi: fix type issue in ni_tio.c Ravishankar Karkala Mallikarjunayya
2016-03-10 10:42 ` Ian Abbott
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1457966343.11972.94.camel@perches.com \
--to=joe@perches.com \
--cc=abbotti@mev.co.uk \
--cc=devel@driverdev.osuosl.org \
--cc=geliangtang@163.com \
--cc=gregkh@linuxfoundation.org \
--cc=hsweeten@visionengravers.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ravishankarkm32@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox