From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965139AbcCNOjQ (ORCPT ); Mon, 14 Mar 2016 10:39:16 -0400 Received: from smtprelay0099.hostedemail.com ([216.40.44.99]:47495 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1755904AbcCNOjN (ORCPT ); Mon, 14 Mar 2016 10:39:13 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::,RULES_HIT:41:355:379:541:599:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1540:1593:1594:1711:1730:1747:1777:1792:2194:2199:2393:2559:2562:2692:2828:3138:3139:3140:3141:3142:3352:3622:3865:3867:3871:3872:3874:4321:5007:6261:7903:10004:10400:10848:11026:11232:11657:11658:11783:11914:12043:12296:12438:12517:12519:12740:13069:13311:13357:13439:13894:14659:21080:30012:30054:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:2,LUA_SUMMARY:none X-HE-Tag: plant13_32398b13bf535 X-Filterd-Recvd-Size: 1822 Message-ID: <1457966343.11972.94.camel@perches.com> Subject: Re: [PATCH 5/5] Staging: comedi: Fix type issue in ni_tio.c From: Joe Perches To: Ravishankar Karkala Mallikarjunayya , abbotti@mev.co.uk Cc: hsweeten@visionengravers.com, gregkh@linuxfoundation.org, geliangtang@163.com, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Date: Mon, 14 Mar 2016 07:39:03 -0700 In-Reply-To: <1457953584-31304-5-git-send-email-ravishankarkm32@gmail.com> References: <1457953584-31304-1-git-send-email-ravishankarkm32@gmail.com> <1457953584-31304-5-git-send-email-ravishankarkm32@gmail.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.18.5.1-1ubuntu1 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2016-03-14 at 16:36 +0530, Ravishankar Karkala Mallikarjunayya wrote: > This is a patch to the ni_tio.c file that fixes up a type issues > found by the checkpatch.pl tool. > i.e. Prefer kernel type 'u64' over 'uint64_t' [] > diff --git a/drivers/staging/comedi/drivers/ni_tio.c b/drivers/staging/comedi/drivers/ni_tio.c [] > @@ -189,7 +189,7 @@ static void ni_tio_reset_count_and_disarm(struct ni_gpct *counter) >  static uint64_t ni_tio_clock_period_ps(const struct ni_gpct *counter, >          unsigned generic_clock_source) >  { > - uint64_t clock_period_ps; > + u64 clock_period_ps; Please don't blinkeredly fix checkpatch messages. Understand the code, not just the checkpatch output. This function returns a uint64_t, maybe it should be converted to u64 as well.